Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purpose of attention stats #79

Open
taha-yassine opened this issue Oct 18, 2024 · 0 comments
Open

Purpose of attention stats #79

taha-yassine opened this issue Oct 18, 2024 · 0 comments

Comments

@taha-yassine
Copy link

I'm currently studying the code to get a better sense of how the method works.

In

logits, kvcache, scores, stats = xfmr(xfmr_weights, model_params, next_token, cur_pos, freqs_cis[cur_pos:cur_pos+1], kvcache)
some attention stats are computed but never used, only the attention scores from the last transformer block (?) are provided to the sampler. Is it just an oversight or am I missing something?

Also, is there a Discord (or similar) to discuss stuff like this? Seems better suited that GH issues.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant