Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastconnects starts also after ethernet cable is un-plugged/re-plugged #24

Open
ThomasGmeinder opened this issue Dec 5, 2016 · 0 comments

Comments

@ThomasGmeinder
Copy link

ThomasGmeinder commented Dec 5, 2016

acmp_start_fast_connect is also called after the Ethernet cable is un-plugged and then re-plugged.

This causes the stream reconnect to fail after Ethernet cable is re-plugged.

Setup:
Compile with #define AVB_1722_1_FAST_CONNECT_ENABLED 1
Flash the EPs with xflash --boot-partition-size 458752
Connect streams bidirectionally.
Now xrun --xscope the binary on both Endpoints.

Scenario:
EP0 and EP1 boot with fastconnect. Streams are re-connected automatically bidirectionally.
Unplug-replug EP1.
EP1 prints again: Issuing fast connect for 0
Stream EP0->EP1 reconnects and locks
Stream EP1->EP0 does not reconnect.

This can be fixed by making sure that acmp_start_fast_connect is only called once after boot.
E.g. by using a flag:
if(!fast_connect_started) { // Call this only after boot, not after unplug-replug
acmp_start_fast_connect(i_eth);
fast_connect_started = 1;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant