Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UAC2 mode does not come out of input underflow when FS=16k and ch=2 #434

Open
ed-xmos opened this issue Oct 14, 2024 · 0 comments
Open

UAC2 mode does not come out of input underflow when FS=16k and ch=2 #434

ed-xmos opened this issue Oct 14, 2024 · 0 comments

Comments

@ed-xmos
Copy link
Contributor

ed-xmos commented Oct 14, 2024

The problem is that in this case the min_packet_size is 12.
The exit for "in underflow" is fillLevel between 2* and 3* min_packet_size which is 24 <= size < 36.

if ((fillLevel >= (min_pkt_size*2)) && (fillLevel < (min_pkt_size*3)))

However the drain function for the input buffer stops at fillLevel 40 which is 2 * max_packet_size. So the window is never hit and it stays in underflow.

} while (fillLevel > 2 * max_pkt_size);

SO basically if 2 * max_packet_size > 3 * min_packet_size there is an issue.

ed-xmos added a commit to ed-xmos/lib_xua that referenced this issue Oct 14, 2024
ed-xmos added a commit to ed-xmos/lib_xua that referenced this issue Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant