Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IgnoreUnmatchedProperties for map types #118

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

bdovaz
Copy link
Contributor

@bdovaz bdovaz commented Feb 12, 2024

Fixes #90

@bdovaz
Copy link
Contributor Author

bdovaz commented Feb 12, 2024

@xoofx I think I fixed all the errors but now I get a GitHub API rate limit error:

image

@xoofx xoofx merged commit 0aaf634 into xoofx:master Feb 13, 2024
1 check passed
@xoofx
Copy link
Owner

xoofx commented Feb 13, 2024

Thanks!

@xoofx
Copy link
Owner

xoofx commented Feb 13, 2024

I think I fixed all the errors but now I get a GitHub API rate limit error:

There was a bug in dotnet-releaser that were matching old version of SharpYaml back in 2013 (fixed here), and so it was trying to retrieve the entire commit history.

I will retry it later to see if I can publish it.

@bdovaz bdovaz deleted the fix-IgnoreUnmatchedProperties-maps branch February 13, 2024 05:30
@bdovaz
Copy link
Contributor Author

bdovaz commented Feb 13, 2024

Ok thank you and please publish a new SharpYaml NuGet version.

Thanks!

@bdovaz
Copy link
Contributor Author

bdovaz commented Feb 13, 2024

@bdovaz
Copy link
Contributor Author

bdovaz commented Feb 13, 2024

Thanks @xoofx! Already available!

Today I'm testing this new version thoroughly to see if all my use cases have been solved with this fix and if I see anything I'll create PR quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore unmapped properties in YAML
2 participants