-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: overhaul status chart design #57
Conversation
feat(no-ref): add package version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the new styling. There is no consistency between it and the rest of the website. It also rises accessibility concerns.
However, i do like the new date formatting.
related to 3cdb4be Adjusted fill style and border width to previous values. If you were referring to the removal of points with accessibility concerns, I feel like not having them renders a clearer and easier to view graph than leaving them in (View second attachment). I also think that a subtle smoothness of the curves benefits the design a lot. Example for similar chart on discordstatus.com |
In my opinion, the unconstrained behaviour of the lines, does not match our relatively calculated and streamlined approach on design. Adding the points back, provides some clarity on the expected positioning of data points. You cannot really compare one component to another one on another website with a whole different design philosophy. |
Alright, what about the points? I think it'd be nice to remove them. If you still need exact info on a specific record, you can still hover over the chart to reveal exact info |
The points need to stay, we can talk about making them smaller, but in the current design - they are necessary. |
I think these changes would make the status page chart a bit prettier.
Changes:
pointStyle
tofalse
hh:mm a
(I think the mention of the day is unnecessary and introduces clutter)tension
to0.15
for a smoother linefill
tofalse
Screenshot of reworked chart: