Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: overhaul status chart design #57

Closed
wants to merge 5 commits into from
Closed

Conversation

crnvl
Copy link
Member

@crnvl crnvl commented Oct 26, 2023

I think these changes would make the status page chart a bit prettier.

Changes:

  • set pointStyle to false
  • change label date format to hh:mm a (I think the mention of the day is unnecessary and introduces clutter)
  • set line tension to 0.15 for a smoother line
  • set fill to false

Screenshot of reworked chart:
image

@crnvl crnvl added the enhancement New feature or request label Oct 26, 2023
@crnvl crnvl requested a review from ConnysCode October 26, 2023 11:38
@ConnysCode ConnysCode changed the base branch from production to development October 26, 2023 11:51
Copy link
Member

@ConnysCode ConnysCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the new styling. There is no consistency between it and the rest of the website. It also rises accessibility concerns.

However, i do like the new date formatting.

@crnvl
Copy link
Member Author

crnvl commented Oct 26, 2023

related to 3cdb4be

Adjusted fill style and border width to previous values. If you were referring to the removal of points with accessibility concerns, I feel like not having them renders a clearer and easier to view graph than leaving them in (View second attachment). I also think that a subtle smoothness of the curves benefits the design a lot.

Changes:
image

Example for similar chart on discordstatus.com
image

@ConnysCode
Copy link
Member

related to 3cdb4be

Adjusted fill style and border width to previous values. If you were referring to the removal of points with accessibility concerns, I feel like not having them renders a clearer and easier to view graph than leaving them in (View second attachment). I also think that a subtle smoothness of the curves benefits the design a lot.

Changes: image

Example for similar chart on discordstatus.com image

In my opinion, the unconstrained behaviour of the lines, does not match our relatively calculated and streamlined approach on design. Adding the points back, provides some clarity on the expected positioning of data points.

You cannot really compare one component to another one on another website with a whole different design philosophy.

@crnvl
Copy link
Member Author

crnvl commented Oct 26, 2023

The reference image was meant to visualise, how another (quite big) service also does not use points while having a very accessible chart.
image
On lower resolution screens, points are very close to another and introduce noise to the field of view. Furthermore, smoothing the line helps with overflowing edges as shown in the image above.

@ConnysCode
Copy link
Member

The reference image was meant to visualise, how another (quite big) service also does not use points while having a very accessible chart. image On lower resolution screens, points are very close to another and introduce noise to the field of view. Furthermore, smoothing the line helps with overflowing edges as shown in the image above.

Yes, i do and did agree with smoothing the lines.

@crnvl
Copy link
Member Author

crnvl commented Oct 26, 2023

Alright, what about the points? I think it'd be nice to remove them. If you still need exact info on a specific record, you can still hover over the chart to reveal exact info

@ConnysCode
Copy link
Member

Alright, what about the points? I think it'd be nice to remove them. If you still need exact info on a specific record, you can still hover over the chart to reveal exact info

The points need to stay, we can talk about making them smaller, but in the current design - they are necessary.

@ConnysCode ConnysCode closed this Nov 18, 2023
@ConnysCode ConnysCode deleted the feat/graph-overhaul branch November 18, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants