Add cache examples, update to latest actions #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
karlhorky
commented
Aug 13, 2024
ybiquitous
requested changes
Aug 13, 2024
There was a problem hiding this comment.
@karlhorky Thanks for the pull request!
Overall LGTM, but I've left some reviews. Can you take a look?
Co-authored-by: Masafumi Koba <[email protected]>
Co-authored-by: Masafumi Koba <[email protected]>
From the docs: https://github.com/nvm-sh/nvm#:~:text=In%20place%20of,version%20of%20node > In place of a version pointer like "14.7" or "16.3" or "12.22.1", you can use the following special default aliases with `nvm install`, `nvm use`, `nvm run`, `nvm exec`, `nvm which`, etc: > > - `node`: this installs the latest version of [`node`](https://nodejs.org/en/)
|
We have to update 
https://github.com/ybiquitous/using-nvm-on-github-action/pull/3/checks#step:11:8 |
Maybe, pnpm v8 dropped support for Node.js v14: I upgraded to v20.16.0 (latest LTS) in this commit: Since new versions of |
karlhorky
added a commit
to karlhorky/github-tricks
that referenced
this pull request
Aug 14, 2024
ybiquitous
approved these changes
Aug 14, 2024
|
Glad to help :) Thanks for the guidance, review and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2