Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pear diff php deprecations #4536

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Conversation

marcovtwout
Copy link
Member

@marcovtwout marcovtwout commented Sep 27, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Tests pass? ✔️
Fixed issues #4534

@what-the-diff
Copy link

what-the-diff bot commented Sep 27, 2023

PR Summary

  • Bug Fix for PHP 8.2 Compatibility
    The 'gii/components/Pear/Text/Diff' part of our software had an outdated approach to handling dynamic properties, which was causing issues with the newer version of PHP (8.2). That issue is addressed and fixed now.

    • File impacted: framework/gii/components/Pear/Text/Diff.php
  • Enhancements in Text_Diff_Engine_native Class
    We've added public properties to the Text_Diff_Engine_native class. It'll improve the way this class interacts with the other parts of our software, leading to an overall improved performance.

    • File impacted: framework/gii/components/Pear/Text/Diff/Engine/native.php
  • Improvement in Mapped Class Constructor Invocation
    We've improved the way the 'Mapped' class's constructor is invoked in 'gii/components/Pear/Text/Diff/Mapped.php'. As a result, the Mapped class will now initialize more effectively.

    • File impacted: framework/gii/components/Pear/Text/Diff/Mapped.php

@marcovtwout marcovtwout merged commit 0361fac into master Nov 14, 2023
24 checks passed
@marcovtwout marcovtwout deleted the 4534-fix-pear-diff-php-deprecations branch November 14, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants