Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cliget shows black text on dark background #59

Open
j000 opened this issue Jan 20, 2018 · 4 comments
Open

cliget shows black text on dark background #59

j000 opened this issue Jan 20, 2018 · 4 comments

Comments

@j000
Copy link

j000 commented Jan 20, 2018

Please set foreground colours everywhere you set background colours.
I'm using dark desktop theme and Firefox follows it. Now I'm getting black text (default) on dark background (from css, default is light grey).
screenshot_20180120_110119
screenshot_20180120_110139

@zaidka
Copy link
Owner

zaidka commented Apr 30, 2018

This looks like a bug in Firefox itself. Cliget uses browser styles and doesn't define any color or background color attributes in CSS.

Will see if we can somehow detect if a dark theme is being used and correct the styles accordingly.

@j000
Copy link
Author

j000 commented Apr 30, 2018

If Cliget does not set any styles please close this issue :)

I have another extension with same problems, so it's definitely Firefox's fault.

@zaidka
Copy link
Owner

zaidka commented Apr 30, 2018

There might still be something we can do about it. I'm thinking the function getComputedStyle() can help here to detect if a dark theme is being used.

@pinophyta
Copy link

Maybe an option/checkbox in settings page for white bg? I use black bg for newtab/blank and having the same issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants