Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): refacto gpu bench workflows to reduce duplicates #1806

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

soonum
Copy link
Contributor

@soonum soonum commented Nov 21, 2024

Now there is only one entry point to trigger benchmarks manually. This entry point uses a sub-workflow responsible for provisioning and running the benchmarks.
A weekly workflow is also created with all the targets needed.

This also adds the possibility to run throughput benchmarks on-demand.

Now there is only one entry point to trigger benchmarks manually.
This entry point uses a sub-workflow responsible for provisioning
and running the benchmarks.
A weekly workflow is also created with all the targets needed.

This also adds the possibility to run throughput benchmarks
on-demand.
@soonum soonum added the ci label Nov 21, 2024
@soonum soonum self-assigned this Nov 21, 2024
@soonum
Copy link
Contributor Author

soonum commented Nov 21, 2024

Once this one is done and merged, I'll do the same for ERC20 GPU benchmarks.

Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good, did you test this ? or I'm guessing you can't because of the workflow not in main rule ?

@soonum
Copy link
Contributor Author

soonum commented Nov 21, 2024

Looks generally good, did you test this ? or I'm guessing you can't because of the workflow not in main rule ?

Yes I have to merge it first and then debug.

@soonum soonum merged commit 9da58f6 into main Nov 21, 2024
163 checks passed
@soonum soonum deleted the dt/ci/refacto_gpu_bench branch November 21, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants