Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tha_sidebars_* vs tha_sidebar_* hooks? #22

Open
slobodan opened this issue Nov 10, 2013 · 2 comments
Open

tha_sidebars_* vs tha_sidebar_* hooks? #22

slobodan opened this issue Nov 10, 2013 · 2 comments

Comments

@slobodan
Copy link

Hey,

Wanted to check if I got this right. Is this how sidebar hooks are meant to be used?

mockup

@Cais
Copy link

Cais commented Nov 10, 2013

This is how I applied them to my implementation in Opus Primus: https://github.com/Cais/opus-primus/blob/master/stanzas/tha/tha-support.php#L83 ... although I do have to review the implementation itself, I do not see any changes that will affect that part of the code.

@slobodan
Copy link
Author

Thanks @Cais that's very similar to what I had in mind. I was thinking of having _top and _bottom hooks inside the sidebar elements, but in most situations I doubt that would make a difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants