Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protobuf support doesn't work out-of-the-box…? #21057

Open
1 task done
hedefalk opened this issue Nov 22, 2024 · 2 comments
Open
1 task done

Protobuf support doesn't work out-of-the-box…? #21057

hedefalk opened this issue Nov 22, 2024 · 2 comments
Labels
bug [core label] documentation [core label]

Comments

@hedefalk
Copy link

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

It sounds to me that protobuf "should just work". Docs link to "protols" https://github.com/coder3101/protols while the code references:

protobuf-language-server:

https://github.com/zed-industries/zed/blob/114c4621433eb948b87fa5f4f41df8af6601f66e/extensions/proto/src/proto.rs

With this plugin installed I just get

Language server error: protobuf-language-server

protobuf-language-server not found in PATH
-- stderr--

I now installed a "protols" unto path with nix:

which protols
/run/current-system/sw/bin/protols

and stuck that into settings as:

"lsp": {
    ...
    "protobuf-language-server": {
      "binary": {
        "path": "protols"
      }
    }
}

Am I misunderstanding what's needed here? Otherwise, maybe that should go into the docs page over at https://zed.dev/docs/languages/proto

Environment

Zed: v0.162.5 (Zed)
OS: macOS 15.1.0
Memory: 64 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log

@hedefalk hedefalk added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Nov 22, 2024
@SturdyFool10
Copy link

its an extension called proto IIRC

@notpeter notpeter added documentation [core label] and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Nov 23, 2024
@notpeter
Copy link
Member

Yeah, docs need some love. I tried to add some formatting docs as the docs very sparse but I incorrectly added the link to ProtoLS (oops).

Extension was originally written with protobuf-language-server in mind, protols is not super well tested. I've commented out the part of the docs I'm less sure about until I have a chance to test further next week.

Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug [core label] documentation [core label]
Projects
None yet
Development

No branches or pull requests

3 participants