Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Benchmark] Add verification logic #384

Open
sea212 opened this issue Nov 26, 2021 · 1 comment
Open

[Benchmark] Add verification logic #384

sea212 opened this issue Nov 26, 2021 · 1 comment
Labels
p:high High priority, prioritize the resolution of this issue t:enhancement The issue described an enhancement

Comments

@sea212
Copy link
Member

sea212 commented Nov 26, 2021

Currently the results of the benchmarks are not verified. Consequently, we have no way to know whether the expected benchmark behavior is equal to the actual benchmark behavior, eventually deriving weights based on incorrect benchmarks.
@sea212 sea212 added p:low Low priority, resolution of this issue can wait t:enhancement The issue described an enhancement labels Nov 26, 2021
@sea212 sea212 added p:medium Medium priority, this issue can wait but should be done fairly soon and removed p:low Low priority, resolution of this issue can wait labels Apr 2, 2024
@maltekliemann maltekliemann added p:high High priority, prioritize the resolution of this issue and removed p:medium Medium priority, this issue can wait but should be done fairly soon labels May 3, 2024
@maltekliemann
Copy link
Contributor

Should be solved by adding test cases to all benchmarks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p:high High priority, prioritize the resolution of this issue t:enhancement The issue described an enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sea212 @maltekliemann