Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prediction-markets] Deposit warnings into log on accounting problems #605

Open
maltekliemann opened this issue May 10, 2022 · 2 comments
Open
Labels
p:low Low priority, resolution of this issue can wait t:enhancement The issue described an enhancement

Comments

@maltekliemann
Copy link
Contributor

In certain situations we need to make assumptions on the availability of funds. For example, when slashing the AdvisoryBond when rejecting an advised market, we make the assumption that the bond is actually reserved for the market creator. This assumption is correct if our code is correct.

But it would be good to receive a warning message if there's an accounting problem. We already have this in place in some places, but should have this everywhere.

@maltekliemann maltekliemann added p:low Low priority, resolution of this issue can wait t:enhancement The issue described an enhancement labels May 10, 2022
@maltekliemann maltekliemann changed the title Deposit warnings into log on accounting problems [prediction-markets] Deposit warnings into log on accounting problems May 12, 2022
@sea212
Copy link
Member

sea212 commented Jul 10, 2022

I think that this is an important point. We have not complete transparency of misbehavior of the chain, and when such things as you mentioned happened, the node should definitely log this to make us aware of such things happening. Increasing the priority to medium.

@sea212 sea212 added p:medium Medium priority, this issue can wait but should be done fairly soon and removed p:low Low priority, resolution of this issue can wait labels Jul 10, 2022
@maltekliemann
Copy link
Contributor Author

This is fixed with regards to bonds, but somebody should check if there's anything else that should be logged.

@maltekliemann maltekliemann added p:low Low priority, resolution of this issue can wait and removed p:medium Medium priority, this issue can wait but should be done fairly soon labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p:low Low priority, resolution of this issue can wait t:enhancement The issue described an enhancement
Projects
None yet
Development

No branches or pull requests

2 participants