Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache account ids? #644

Open
maltekliemann opened this issue May 21, 2022 · 1 comment
Open

Cache account ids? #644

maltekliemann opened this issue May 21, 2022 · 1 comment
Labels
p:low Low priority, resolution of this issue can wait t:enhancement The issue described an enhancement

Comments

@maltekliemann
Copy link
Contributor

maltekliemann commented May 21, 2022 •
edited
Loading

Regarding account_id(), the treasury pallet's documentation says the following about into_sub_account:

This actually does computation. If you need to keep using it, then make sure you cache the value and only call this once. [link]

We use this type of account generation in grand fashion. Should we cache market/pool accounts and trade chain storage for computation time?
@maltekliemann maltekliemann added p:low Low priority, resolution of this issue can wait t:question The issue contains a question labels May 21, 2022
@sea212
Copy link
Member

sea212 commented Jul 10, 2022 •
edited
Loading

Absolutely. Let's keep it a low priority for now because it is an optimizations that is not needed right now, but eventually will be.

@sea212 sea212 added t:enhancement The issue described an enhancement and removed t:question The issue contains a question labels Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p:low Low priority, resolution of this issue can wait t:enhancement The issue described an enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sea212 @maltekliemann