Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Network] Number of forks and reorgs is too high #697

Open
sea212 opened this issue Jul 7, 2022 · 2 comments · Fixed by #706
Open

[Network] Number of forks and reorgs is too high #697

sea212 opened this issue Jul 7, 2022 · 2 comments · Fixed by #706
Labels
l:L Solving the issue takes weeks p:medium Medium priority, this issue can wait but should be done fairly soon t:bug The issue describes a bug

Comments

@sea212
Copy link
Member

sea212 commented Jul 7, 2022

It seems there is a problem during the author selection, since most of the time most of the collators try to produce a block simultaneously, which leads to an unacceptable high number of forks and reorgs.

@sea212 sea212 added p:high High priority, prioritize the resolution of this issue t:bug The issue describes a bug labels Jul 7, 2022
@sea212 sea212 added this to the v0.3.5 milestone Jul 7, 2022
@sea212
Copy link
Member Author

sea212 commented Jul 10, 2022

As it turns out the eligibleCount of the author-slot-filter pallet is set to 50. Respecting the current active collator set size, this leads to the situation that every collator tries to produce every block, which causes a high number of forks and reorgs. Setting eligibleCount to 1 will result in only one collator being eligible for producing the next block, significantly reducing the number of forks and reorgs in the network. Should a collator not produce a block within a predetermined timespan, another collator will become eligible to produce the next block. Since the eligible collator is selected randomly, the number of produced blocks should evenly distribute along every collator in the active collator set.
Governance will be used soon to determine whether the participants of the network embrace that change.

@sea212
Copy link
Member Author

sea212 commented Aug 12, 2022

Reopening because the measurement reduced the forks, but didn't eliminate them completely.

@sea212 sea212 reopened this Aug 12, 2022
@sea212 sea212 added p:medium Medium priority, this issue can wait but should be done fairly soon and removed p:high High priority, prioritize the resolution of this issue labels Aug 12, 2022
@sea212 sea212 removed this from the v0.3.4 milestone Aug 20, 2022
@sea212 sea212 added this to the v0.3.7 milestone Sep 14, 2022
@sea212 sea212 modified the milestones: v0.3.7, v0.3.8 Sep 27, 2022
@sea212 sea212 added the l:L Solving the issue takes weeks label Nov 8, 2022
@sea212 sea212 modified the milestones: v0.3.8, v0.3.9 Nov 22, 2022
@sea212 sea212 modified the milestones: v0.3.9, v0.4.0 Mar 28, 2023
@sea212 sea212 modified the milestones: v0.3.10, v0.3.11 Jul 20, 2023
@sea212 sea212 removed this from the v0.3.11 milestone Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l:L Solving the issue takes weeks p:medium Medium priority, this issue can wait but should be done fairly soon t:bug The issue describes a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant