Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM] Use twox_64_concat hash function for MarketIdsPer* #718

Open
maltekliemann opened this issue Jul 19, 2022 · 1 comment
Open

[PM] Use twox_64_concat hash function for MarketIdsPer* #718

maltekliemann opened this issue Jul 19, 2022 · 1 comment
Labels
p:low Low priority, resolution of this issue can wait t:enhancement The issue described an enhancement

Comments

@maltekliemann
Copy link
Contributor

I don't really see how users have much control over the keys here.
@maltekliemann maltekliemann added p:low Low priority, resolution of this issue can wait t:question The issue contains a question labels Jul 19, 2022
@maltekliemann maltekliemann changed the title Why is MarketIdsPer* hashed with Blake2_128Concat Why is MarketIdsPer* hashed with Blake2_128Concat instead of twox_64_concat? Jul 19, 2022
@sea212 sea212 added t:enhancement The issue described an enhancement and removed t:question The issue contains a question labels Jul 19, 2022
@sea212
Copy link
Member

sea212 commented Jul 19, 2022

since we use incrementing timeframes or block numbers, it can be the more lightweight but less secure twox_64_concat. However, the change requires a storage migration. The optimization is not needed yet, hence I agree with the low priority on this.

@sea212 sea212 changed the title Why is MarketIdsPer* hashed with Blake2_128Concat instead of twox_64_concat? [PM] Use twox_64_concat hash function for MarketIdsPer* Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p:low Low priority, resolution of this issue can wait t:enhancement The issue described an enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sea212 @maltekliemann