Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZIP-0 Only allow one dispute in prediction-markets #905

Closed
Chralt98 opened this issue Dec 14, 2022 · 2 comments
Closed

ZIP-0 Only allow one dispute in prediction-markets #905

Chralt98 opened this issue Dec 14, 2022 · 2 comments
Assignees
Labels
l:M Solving the issue takes days p:high High priority, prioritize the resolution of this issue t:enhancement The issue described an enhancement

Comments

@Chralt98
Copy link
Member

Chralt98 commented Dec 14, 2022

The point of this section of ZIP-0 was that the dispute extrinsic is used to pass control to the MDM. From there on, all further interaction should go via the MDM. So the whole disputes parameter here should go.

There should only be one dispute regardless of what the MDM is, so the check shouldn't go into the MDM, but into prediction-markets (or rather, the whole Disputes object should not map to a vector of disputes).

simple-disputes does not work with the current implementation, when we only allow one dispute. So there needs to be a possibility to dispute inside the simple-disputes MDM (rather than in prediction-markets).

Many things like Disputes and the dispute bond managing should go into simple-disputes and removed from prediction-markets.

After the first dispute is called, everything should happen inside the MDMs.

@Chralt98 Chralt98 added p:medium Medium priority, this issue can wait but should be done fairly soon t:enhancement The issue described an enhancement l:M Solving the issue takes days labels Dec 14, 2022
@Chralt98 Chralt98 self-assigned this Dec 14, 2022
@Chralt98 Chralt98 mentioned this issue Dec 14, 2022
@Chralt98 Chralt98 added this to the v0.3.9 milestone Jan 4, 2023
@Chralt98
Copy link
Member Author

Chralt98 commented Jan 5, 2023

Strongly linked to #916

@Chralt98 Chralt98 added p:high High priority, prioritize the resolution of this issue and removed p:medium Medium priority, this issue can wait but should be done fairly soon labels Jan 5, 2023
@sea212 sea212 modified the milestones: v0.3.9, v0.4.0 Jun 13, 2023
@sea212 sea212 modified the milestones: v0.3.10, v0.3.11 Jul 20, 2023
@sea212 sea212 removed this from the v0.3.11 milestone Aug 3, 2023
@Chralt98
Copy link
Member Author

Fixed by #938

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l:M Solving the issue takes days p:high High priority, prioritize the resolution of this issue t:enhancement The issue described an enhancement
Projects
None yet
Development

No branches or pull requests

2 participants