-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow @
expressions
#269
allow @
expressions
#269
Conversation
Thank you for your pull request. |
this is a bit above my pay-grade, so please accept my apologies if i am totally misunderstanding how the tests work. i'm trying to follow the examples of
(i'm so unsure of myself that i'm hoping to get feedback before updating the PR) ...or maybe there is a simpler way to just make a foo test...
|
ok wait, this is probably the better place to do it: 959ac23 (maybe not the right way, but i think it should work) |
I think I understood the idea of the test and I think I can get it working, but first we need some general paperwork: Thank you for your contribution. According to the contributing policies of the zopefoundation organization you need to sign a contributor agreement before any non-trivial change can be merged. For details please consult the Contributing guidelines for zopefoundation projects. |
i'm reviewing the document. in the meantime, hopefully we can do this: this pull request (#269) by Raymond Weitekamp (rawwerks) is marked with CC0 1.0 Universal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the linting errors and get the test green.
transformer.py
Line 55-64 must be ammended and __matmul__
be added, or the tests won't pass.
I would suggest to change the test to the more common used structure, where the source_code definition is definied before the test-case.
Thanks for the Pull request.
@rawwerks Thank you for putting your changes into public domain. I'll come up with a new PR containing your changes. |
I created #270 as followup PR. |
@icemac how should I please or approve zopefoundation/.github#8 if it is already merged? I am fine with it, and it makes sense for simple contributions, where people don't want to sign the contributor agreement. |
@loechel Sorry, I did not check what I wrote, I meant: "Please see the changes in …" in case you were not aware of them. |
this commit updates transformers.py to allow
@
expressions. would close #268.