Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.13 and remove Python 3.7 support. #289

Merged
merged 11 commits into from
Oct 9, 2024
Merged

Support Python 3.13 and remove Python 3.7 support. #289

merged 11 commits into from
Oct 9, 2024

Conversation

dataflake
Copy link
Member

Fixes #264

The only AST changes I found were slight changes to type parameters. They gained support for a default value.

@dataflake dataflake requested review from icemac and loechel October 8, 2024 07:11
@dataflake dataflake self-assigned this Oct 8, 2024
@dataflake
Copy link
Member Author

dataflake commented Oct 8, 2024

The failing ubuntu-release-check test is expected - check-python-versions doesn't yet consider Python 3.13 released I guess. Marius is already working on fixing it, see mgedmin/check-python-versions#46

@dataflake
Copy link
Member Author

I have read through https://docs.python.org/3/whatsnew/3.13.html and didn't spot anything obvious that's security-related.

I have eyeballed the diffs for the random and string modules, string has no changes at all and random has a command-line interface but does not introduce any functional changes.

The math module has some inline code optimizations and adds a function (https://docs.python.org/3/library/math.html#math.fma) that doesn't seem less safe than the rest.

@dataflake dataflake changed the title Support Python 3.13 Support Python 3.13 and remove Python 3.7 support. Oct 8, 2024
@dataflake dataflake requested a review from d-maurer October 8, 2024 13:19
setup.py Show resolved Hide resolved
setup.py Show resolved Hide resolved
Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes.

tests/transformer/test_dict_comprehension.py Outdated Show resolved Hide resolved
@dataflake dataflake merged commit 7b8a6b4 into master Oct 9, 2024
23 checks passed
@dataflake dataflake deleted the py313 branch October 9, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python 3.13
4 participants