Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorporate flow logic from DebugView into WriterBase #52

Open
zspitz opened this issue Sep 28, 2020 · 1 comment
Open

Incorporate flow logic from DebugView into WriterBase #52

zspitz opened this issue Sep 28, 2020 · 1 comment
Milestone
3.5

Comments

@zspitz
Copy link
Owner

zspitz commented Sep 28, 2020 •
edited
Loading

DebugView has a mechanism for tracking text flow and wrapping long lines.

It would be nice to incorporate this into WriterVisitorBase, so other writer/visitors could use it as well.
@zspitz zspitz mentioned this issue Sep 28, 2020
Open
@zspitz
Copy link
Owner Author

zspitz commented Sep 30, 2020 •
edited
Loading

This would have an additional benefit. Currently, for the DebugViewWriterVisitor, the path span for a given node includes the whitespace triggered by flow before the node. If WriterVisitorBase was aware of the flow, it could start the path span at the first actual write of the node, ignoring the flow-triggered whitespace.

@zspitz zspitz added this to the 3.3 milestone Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.5
Development

No branches or pull requests
1 participant
@zspitz