-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@peter/detailed metrics #256
Conversation
55a4270
to
3ef8f5e
Compare
94a9591
to
0f36f3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @0g-peterzhb)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @0g-peterzhb)
node/storage-async/src/lib.rs
line 160 at r1 (raw file):
let mut frames = backtrace.frames().to_vec(); if frames.len() > 3 { frames.drain(0..); //Remove the first 3 unnecessary frames to simplify// backtrace
This will remove all the frames?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @0g-peterzhb)
node/storage-async/src/lib.rs
line 147 at r1 (raw file):
move || { // FIXME(zz): Not all functions need `write`. Refactor store usage. let res = f(&*store);
We should print the backtrace here? rx.await
will not return error if the receiver is dropped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 14 of 15 files reviewed, 2 unresolved discussions (waiting on @boqiu and @peilun-conflux)
node/storage-async/src/lib.rs
line 147 at r1 (raw file):
Previously, peilun-conflux wrote…
We should print the backtrace here?
tx.await
will not return error if the receiver is dropped.
Done.
node/storage-async/src/lib.rs
line 160 at r1 (raw file):
Previously, peilun-conflux wrote…
This will remove all the frames?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @0g-peterzhb)
1684e5c
to
acd17bc
Compare
This change is