Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@peter/db split #262

Merged
merged 5 commits into from
Nov 8, 2024
Merged

@peter/db split #262

merged 5 commits into from
Nov 8, 2024

Conversation

0g-peterzhb
Copy link
Contributor

@0g-peterzhb 0g-peterzhb commented Nov 6, 2024

This PR does the following:

  1. separate flow db from data db so the snapshot can contain just the flow db without the data db
  2. data db contains actually data, miner_id, shard_config, finalized indicator
  3. flow db contains merkle, sync event statistics
  4. pad tx after the sync period finished to allow for faster sync up.

This change is Reviewable

@0g-peterzhb 0g-peterzhb marked this pull request as ready for review November 7, 2024 12:12
Copy link
Contributor

@boqiu boqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 18 of 18 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @peilun-conflux)

Copy link
Contributor

@peilun-conflux peilun-conflux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 5 files at r1, 18 of 18 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @0g-peterzhb)


node/storage/src/log_store/log_manager.rs line 439 at r2 (raw file):

                        }
                        std::result::Result::Err(_) => {
                            debug!("Unable to get pad data, start_index={}", start_index);

This is possible when we reach the max tx seq, so maybe add a sleep here to avoid a spin loop?

Copy link
Contributor

@peilun-conflux peilun-conflux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @0g-peterzhb)

Copy link
Contributor Author

@0g-peterzhb 0g-peterzhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @0g-peterzhb)


node/storage/src/log_store/log_manager.rs line 439 at r2 (raw file):

Previously, peilun-conflux wrote…

This is possible when we reach the max tx seq, so maybe add a sleep here to avoid a spin loop?

resolved.

@0g-peterzhb 0g-peterzhb merged commit fae2d5e into main Nov 8, 2024
6 of 7 checks passed
@0g-peterzhb 0g-peterzhb deleted the @peter/db-split branch November 8, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants