-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@peter/db split #262
@peter/db split #262
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 18 of 18 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @peilun-conflux)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 5 files at r1, 18 of 18 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @0g-peterzhb)
node/storage/src/log_store/log_manager.rs
line 439 at r2 (raw file):
} std::result::Result::Err(_) => { debug!("Unable to get pad data, start_index={}", start_index);
This is possible when we reach the max tx seq, so maybe add a sleep here to avoid a spin loop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @0g-peterzhb)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @0g-peterzhb)
node/storage/src/log_store/log_manager.rs
line 439 at r2 (raw file):
Previously, peilun-conflux wrote…
This is possible when we reach the max tx seq, so maybe add a sleep here to avoid a spin loop?
resolved.
This PR does the following:
This change is