Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import cdk-validium-node genesis improvement #3780

Merged
merged 7 commits into from
Sep 6, 2024
Merged

import cdk-validium-node genesis improvement #3780

merged 7 commits into from
Sep 6, 2024

Conversation

joanestebanr
Copy link
Contributor

@joanestebanr joanestebanr commented Aug 29, 2024 •
edited
Loading

Closes #3778, #3779

What does this PR do?

Add param rollupManagerCreationBlockNumber in genesis file:

    "root": "0x3f86b09b43e3e49a41fc20a07579b79eba044253367817d5c241d23c0e2bc5c9",
    "genesisBlockNumber": 16896721,
    "rollupManagerCreationBlockNumber": 16896721,
    "genesis": [

Reviewers

Main reviewers:

Codeowner reviewers:

  • @-Alice
  • @-Bob

@cla-bot cla-bot bot added the cla-signed label Aug 29, 2024
@joanestebanr joanestebanr self-assigned this Aug 29, 2024
@joanestebanr joanestebanr added this to the v0.7.4 milestone Aug 29, 2024
@joanestebanr joanestebanr marked this pull request as ready for review September 2, 2024 15:07
ARR552
ARR552 requested changes Sep 3, 2024
View reviewed changes
synchronizer/synchronizer.go Outdated Show resolved Hide resolved
etherman/etherman.go Outdated Show resolved Hide resolved
etherman/etherman.go Outdated Show resolved Hide resolved
state/block.go Show resolved Hide resolved
synchronizer/synchronizer_test.go Outdated Show resolved Hide resolved
synchronizer/synchronizer_test.go Outdated Show resolved Hide resolved
@joanestebanr joanestebanr requested a review from ARR552 September 3, 2024 14:35
@joanestebanr joanestebanr merged commit f9111f4 into release/v0.7.4 Sep 6, 2024
16 checks passed
@joanestebanr joanestebanr deleted the feature/sync_genesis_improvement branch September 6, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@invocamanman invocamanman invocamanman left review comments

@agnusmor agnusmor agnusmor approved these changes

@ToniRamirezM ToniRamirezM Awaiting requested review from ToniRamirezM ToniRamirezM is a code owner

@tclemos tclemos Awaiting requested review from tclemos tclemos is a code owner

@ARR552 ARR552 Awaiting requested review from ARR552 ARR552 is a code owner

Assignees

@joanestebanr joanestebanr

Labels
cla-signed config synchronizer
Projects
None yet
Milestone
v0.7.4
Development

Successfully merging this pull request may close these issues.
4 participants
@joanestebanr @ARR552 @invocamanman @agnusmor