Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve IsValueType for GenericSig #529

Closed
wants to merge 1 commit into from
Closed

Improve IsValueType for GenericSig #529

wants to merge 1 commit into from

Conversation

CreateAndInject
Copy link
Contributor

No description provided.

@wtfsck
Copy link
Contributor

wtfsck commented Oct 19, 2023

Can you explain why this is an improvement?

@CreateAndInject
Copy link
Contributor Author

Since we know if it's ValueType exactly in these cases.

@CreateAndInject
Copy link
Contributor Author

CreateAndInject commented Oct 19, 2023 •
edited
Loading

Reflection check type constraint also:
image

@wtfsck
Copy link
Contributor

wtfsck commented Oct 27, 2023

This resolves a type which no other function in that file does. It's better if you create an extension method to your code and add this code to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CreateAndInject @wtfsck