Add new AllowByRefLike generic parameter attribute
#557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtfsck
requested changes
May 28, 2024
Oh yeah, I missed that! The code should be correct now.
To be honest, I have no clue. The GitHub account associated with it appears to have been deleted in a way that has deleted all content from the account including comments, etc. instead of replacing them with the typical @ghost user. |
wtfsck
approved these changes
May 28, 2024
|
Thanks, merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See:
https://github.com/dotnet/runtime/blob/main/docs/design/features/byreflike-generics.md
dotnet/runtime#102671
https://github.com/dotnet/runtime/blob/9daa4b41eb9f157e79eaf05e2f7451c9c8f6dbdc/src/coreclr/inc/corhdr.h#L847
The code responsible for this flag appears to be in the main branch of the runtime already.