[BUGFIX] Mettre à jour le statut d'une RA quand elle est recréée #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathieuGilet
added
team-captains
|
Une fois l'application déployée, elle sera accessible à cette adresse https://bot-pr467.review.pix.fr |
MathieuGilet
changed the title
VincentHardouin
approved these changes
Nov 14, 2024
|
attention au titre qui est trompeur : on ne merge pas la RA, mais la ligne en base de donnée, on peut renommer en |
MathieuGilet
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍂 Problème
Il existe actuellement une contrainte d'unicité sur le nom d'une RA dans la table
review-apps. Cependant, il arrive parfois qu'une PR nécessite d'être fermée puis rouverte lorsque les addons n'ont pas été bien provisionnés lors du déploiement comme pour la PR suivante. Aujourd'hui, cela cause une erreur car la contrainte est violée.🌰 Proposition
Merger une RA plutôt que de renvoyer une erreur quand elle est recrée