[BUGFIX] Ne pas appeler le usecase "reward user" si l'utlilisateur n'est pas connecte (PIX-15528) #10697
+102
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
La-toile-cosmique
added
👀 Tech Review Needed
team-evaluation
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
La-toile-cosmique
force-pushed
the
pix-15528-prevent-reward-for-empty-user-id
branch
7 times, most recently
from
4a8ff35
to
df5031b
Compare
|
Le titre devrait être en français 🙏 |
VincentHardouin
approved these changes
Dec 3, 2024
🇺🇸 |
La-toile-cosmique
changed the title
Libouk
approved these changes
Dec 3, 2024
Libouk
added
Tech Review OK
🚀 Ready to Merge
Func Review OK
pix-service-auto-merge
force-pushed
the
pix-15528-prevent-reward-for-empty-user-id
branch
from
df5031b
to
344d34c
Compare
pix-service-auto-merge
deleted the
pix-15528-prevent-reward-for-empty-user-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Si un utilisateur non identifie repond a une question, on declenche le calcul de son attestation. Cela donne des requetes incoherentes et des problemes de charge. En effet au lieu de chercher les informations de l'utilisateur en cours, on parcourt les donnees de tous les utilisateurs non reconcilies.
🎁 Proposition
Mettre des verifications aux differentes etapes pour eviter ce cas de figure.
🎅 Pour tester
Tests au vert.
Le deploiement ne doit plus crasher la recette.
Essayer le parcours statique avec un utilisateur non connecte