-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LG-15059: Socure timeout page #11572
base: main
Are you sure you want to change the base?
Conversation
# flash[:error] = I18n.t('errors.doc_auth.polling_timeout') | ||
# TODO: redirect to try again page LG-14873/14952/15059 | ||
render plain: 'Technical difficulties!!!', status: :ok | ||
redirect_to idv_socure_errors_timeout_path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏿
do we also need this behavior for the hybrid socure flow? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 ... what do you think about simplifying the path here and changing socure_errors
to errors
since its already in the socure folder?
app/views/idv/socure/errors/[...].html.erb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems like this view is almost identical to the view needed for LG-14952 ... if prefer to defer abstraction now, it should be abstracted in LG-14952 ... i added a coment in the ticket for whoever picks it up
allow_any_instance_of(ApplicationController).to receive(:current_user).and_return(user) | ||
|
||
user_session = {} | ||
allow(subject).to receive(:user_session).and_return(user_session) | ||
|
||
subject.idv_session.socure_docv_wait_polling_started_at = Time.zone.now | ||
stub_sign_in(user) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
allow_any_instance_of(ApplicationController).to receive(:current_user).and_return(user) | |
user_session = {} | |
allow(subject).to receive(:user_session).and_return(user_session) | |
subject.idv_session.socure_docv_wait_polling_started_at = Time.zone.now | |
stub_sign_in(user) | |
stub_sign_in(user) | |
subject.idv_session.socure_docv_wait_polling_started_at = Time.zone.now |
can we add feature test opting in to IPP from timeout page and clicking |
033d26c
to
ed07bab
Compare
If a user is returned from Socure and is waiting too long for their data to be fetched, they are redirected to the Timeout page where they can either Try again, Try in person (if available), or Cancel. changelog: Upcoming Features, Identity Verification, Socure timeout provides users with options.
Rename Idv::Socure::SocureErrorsController to Idv::Socure::ErrorsController
6a64eed
to
230704a
Compare
can you rebase this to pick up fixes for the reviewapps cluster to be less sad? |
🎫 Ticket
Link to the relevant ticket:
LG-15059
🛠 Summary of changes
When a user is waiting for Socure results that never come, they timeout and are redirected to a Timeout page. There they can try again or, if available, switch to in person IdV.