[DO NOT REVIEW] [WIP] Add Sorbet proof-of-concept #11618
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Why** - Reduce wayfinding when consuming data from other parts of the codebase - Reduce refactoring time for broadly used objects and methods **How** - Adds Sorbet and Tapioca and the initially generated stubs and RBI files - Updates the Gemfile with a specific platform [skip changelog]
lmgeorge
force-pushed
the
lmgeorge/hackathon/progressive-types-sorbet
branch
from
2a83c55 to
e6717ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds Sorbet type checking to the project.
Notable functional changes
:iaa_statusActiveModel relationships- Necessary in order to generate the first-party RBI files
- The table was removed June 2021 from our schema, but the ActiveModel classes were never updated.
RuboCop changes