Fix mail_later Rubocop cop when method called on variable reference #11642
+19
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Internal, Static Analysis, Fix custom linter for configurable mail delivery
Fail if can't check type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Fixes an issue where the custom
mail_laterRubocop cop will fail if checking a method call on a variable reference to a mailer.In doing so, it fixes a separate issue where errors raised in the course of performing Rubocop lint check are not output in the build output.
Previously: #11458 (comment)
Draft: This currently only implements the fix for GitLab output and a failing test case for the underlying error, but not the fix for the error.
📜 Testing Plan
Verify that the build output now displays errors occurring during Rubocop check: https://gitlab.login.gov/lg/identity-idp/-/jobs/1577667
Verify that the lint checks pass.