LG-14948 Try again opens selfie capture camera instead of redo doc auth page. #11661
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changelog: Bug Fixes, Doc Auth, Fix try again button opening up Selfie SDK
theabrad
force-pushed
the
abrad-lg-14948-try-again-bug
branch
from
c276085 to
c667986
Compare
aduth
reviewed
Dec 17, 2024
| immediatelyBeginCapture: true, | ||
| immediatelyBeginCapture: false, |
There was a problem hiding this comment.
Is this the only place we had been passing immediatelyBeginCapture ? Can we remove it altogether?
There was a problem hiding this comment.
Yeah looks like we don't need it. Had to confirm with the team before i outright removed it. Will do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Link to the relevant ticket:
LG-14948
🛠 Summary of changes
Fixed a bug where if a user fail's doc auth and hits "Try again online" it immediatly opens up the selfie camera.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.