Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed remaining inner representation in RemainingInvalidator #252

Merged
merged 7 commits into from
Sep 11, 2023
Merged

Changed remaining inner representation in RemainingInvalidator #252

merged 7 commits into from
Sep 11, 2023

Conversation

galekseev
Copy link
Member

Saves 3 gas for fill order, but adds 3 gas to cancel order.

Before

·······················|···············|·············|·············|·············|···············|··············
|  LimitOrderProtocol  ·  cancelOrder  ·          -  ·          -  ·      44617  ·            1  ·          -  │
·······················|···············|·············|·············|·············|···············|··············
|  LimitOrderProtocol  ·  fillOrder    ·      99269  ·      99281  ·      99275  ·            2  ·          -  │
·······················|···············|·············|·············|·············|···············|··············

After

·······················|···············|·············|·············|·············|···············|··············
|  LimitOrderProtocol  ·  cancelOrder  ·          -  ·          -  ·      44620  ·            1  ·          -  │
·······················|···············|·············|·············|·············|···············|··············
|  LimitOrderProtocol  ·  fillOrder    ·      99266  ·      99278  ·      99272  ·            2  ·          -  │
·······················|···············|·············|·············|·············|···············|··············

@galekseev galekseev requested a review from ZumZoom July 11, 2023 17:29
@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.06% 🎉

Comparison is base (65b2ad0) 85.56% compared to head (da5511d) 86.62%.
Report is 20 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #252      +/-   ##
==========================================
+ Coverage   85.56%   86.62%   +1.06%     
==========================================
  Files          22       23       +1     
  Lines         464      486      +22     
  Branches      112      113       +1     
==========================================
+ Hits          397      421      +24     
+ Misses         67       65       -2
Files Changed Coverage Δ
contracts/libraries/RemainingInvalidatorLib.sol 100.00% <100.00%> (+5.26%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

byshape
byshape requested changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@byshape byshape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, minor comments on the RemainingInvalidatorLib docs.

contracts/libraries/RemainingInvalidatorLib.sol Show resolved Hide resolved
contracts/libraries/RemainingInvalidatorLib.sol Show resolved Hide resolved
@ZumZoom ZumZoom merged commit aa6430a into master Sep 11, 2023
7 checks passed
@ZumZoom ZumZoom deleted the refactor/remaining-invalidator branch September 11, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byshape byshape byshape approved these changes

@ZumZoom ZumZoom ZumZoom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galekseev @ZumZoom @byshape