Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize extension offset bounds checks #259

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

k06a
Copy link
Member

@k06a k06a commented Aug 17, 2023

··························|·············|·············|·············|················
|  fillContractOrder      ·      79716  ·      96816  ·      88266  ·            2  │
··························|·············|·············|·············|················
|  fillContractOrderExt   ·      83675  ·     110458  ·     101530  ·           21  │
··························|·············|·············|·············|················
|  fillOrder              ·      82072  ·     122115  ·     102755  ·          116  │
··························|·············|·············|·············|················
|  fillOrderExt           ·      78541  ·     129658  ·     104014  ·           80  │
··························|·············|·············|·············|················
|  fillOrderTo            ·          -  ·          -  ·     104985  ·            5  │
··························|·············|·············|·············|················
|  fillOrderToWithPermit  ·     127591  ·     137038  ·     131674  ·           14  │
··························|·············|·············|·············|················

=>

··························|·············|·············|·············|················
|  fillContractOrder      ·      79716  ·      96816  ·      88266  ·            2  │
··························|·············|·············|·············|················
|  fillContractOrderExt   ·      83633  ·     110407  ·     101482  ·           21  │
··························|·············|·············|·············|················
|  fillOrder              ·      82072  ·     122115  ·     102755  ·          116  │
··························|·············|·············|·············|················
|  fillOrderExt           ·      78496  ·     129613  ·     103972  ·           80  │
··························|·············|·············|·············|················
|  fillOrderTo            ·          -  ·          -  ·     104985  ·            5  │
··························|·············|·············|·············|················
|  fillOrderToWithPermit  ·     127591  ·     137038  ·     131674  ·           14  │
··························|·············|·············|·············|················

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6a3522b) 82.36% compared to head (989ac53) 82.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   82.36%   82.36%           
=======================================
  Files          23       23           
  Lines         482      482           
  Branches      113      113           
=======================================
  Hits          397      397           
  Misses         85       85           
Files Changed Coverage Δ
contracts/libraries/OffsetsLib.sol 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZumZoom ZumZoom merged commit c2dcfa9 into master Aug 18, 2023
7 checks passed
@ZumZoom ZumZoom deleted the feature/optimize-ext branch August 18, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants