Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(engine): create heropoints class & improve chatmodes #1016

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

ultraviolet-jordan
Copy link
Collaborator

@ultraviolet-jordan ultraviolet-jordan commented Nov 21, 2024

  • Remove heropoints duplicate code by creating a class for it.
  • Improve player chatmodes code.
  • Some imports organizing.

privateChat: ChatModePrivate.ON,
tradeDuel: ChatModeTradeDuel.ON,
};
publicChat: ChatModePublic = ChatModePublic.ON;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure this is an improvement, they are closely related so imo it makes sense to group them

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was ugly and now it is handsome

@Pazaz Pazaz merged commit 9a59d0f into 2004Scape:main Nov 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants