Refactor CI/CD so support and staging jobs are separate, and multiple staging hubs are detected #5813
Workflow file for this run
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
name: Deploy and test hubs | ||
on: | ||
push: | ||
branches: | ||
- main | ||
paths: | ||
# Include changes to the deployer script's folder, but exclude some parts | ||
- deployer/** | ||
- "!deployer/README.md" | ||
- "!deployer/health_check_tests/**" | ||
- "!deployer/commands/generate/billing/**" | ||
- "!deployer/commands/generate/dedicated_cluster/**" | ||
- "!deployer/commands/generate/hub_asset/**" | ||
- "!deployer/commands/generate/resource_allocation/**" | ||
- requirements.txt | ||
- .github/actions/setup-deploy/** | ||
- helm-charts/** | ||
- config/clusters/** | ||
# Exclude the template configuration files | ||
- "!config/clusters/templates/**" | ||
- "!terraform/aws/projects/template.tfvars" | ||
- "!terraform/gcp/projects/cluster.tfvars.template" | ||
- "!eksctl/template.jsonnet" | ||
pull_request: | ||
branches: | ||
- main | ||
paths: | ||
# Include changes to the deployer script's folder, but exclude some parts | ||
- deployer/** | ||
- "!deployer/README.md" | ||
- "!deployer/health_check_tests/**" | ||
- "!deployer/commands/generate/billing/**" | ||
- "!deployer/commands/generate/dedicated_cluster/**" | ||
- "!deployer/commands/generate/hub_asset/**" | ||
- "!deployer/commands/generate/resource_allocation/**" | ||
- requirements.txt | ||
- .github/actions/setup-deploy/** | ||
- helm-charts/** | ||
- config/clusters/** | ||
# Exclude the template configuration files | ||
- "!config/clusters/templates/**" | ||
- "!terraform/aws/projects/template.tfvars" | ||
- "!terraform/gcp/projects/cluster.tfvars.template" | ||
- "!eksctl/template.jsonnet" | ||
# Queue triggered executions of this workflow stemming from pushes to avoid | ||
# deployment conflicts. | ||
# | ||
# By using a different concurrency groups for pull requests and pushes, we | ||
# reduce the risk of cancelling a queued but not started workflow as discussed | ||
# in https://github.com/2i2c-org/infrastructure/issues/3214. | ||
# | ||
# github.head_ref is used to create PR unique concurrency groups, and for | ||
# workflow executions not triggered by a PR we get a dedicated group. | ||
# | ||
# ref: https://docs.github.com/en/actions/using-jobs/using-concurrency | ||
# | ||
concurrency: | ||
group: ${{ github.workflow }}-${{ github.head_ref || 'not-a-pr' }} | ||
cancel-in-progress: false | ||
# This environment variable triggers the deployer to colourise print statements in the | ||
# GitHub Actions logs for easy reading | ||
env: | ||
TERM: xterm | ||
# This may not be required any more, and it may depend on the kubectl version | ||
# we use etc as well. For now, we have it added to avoid issues. | ||
USE_GKE_GCLOUD_AUTH_PLUGIN: "True" | ||
jobs: | ||
# This job runs in Pull Requests and on pushes to the default branch. It identifies | ||
# which files have been added or modified by recent GitHub activity and parsed a list | ||
# to the `deployer generate helm-upgrade-job`s command of the deployer. This command generates | ||
# three lists of dictionaries, which can be read by GitHub Actions as matrix jobs. The | ||
# first set of jobs describes which clusters need their support chart upgraded; the second set | ||
# of jobs describe which staging hubs require upgrading; and the third set of jobs describe | ||
# which production hubs require upgrading. These lists are set as job outputs via GITHUB_ENV | ||
# to be consumed by the later jobs. They are also pretty-printed in a human-readable format | ||
# to the logs, and converted into Markdown tables for posting into GitHub comments. | ||
generate-jobs: | ||
runs-on: ubuntu-latest | ||
outputs: | ||
support-matrix-jobs: ${{ env.support-matrix-jobs }} | ||
staging-matrix-jobs: ${{ env.staging-hub-matrix-jobs }} | ||
prod-hub-matrix-jobs: ${{ env.prod-hub-matrix-jobs }} | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-python@v5 | ||
with: | ||
python-version: "3.11" | ||
# There will almost never be a cache hit on the cache key when this job is | ||
# run, as it is the first of all jobs in this workflow. An exception is if | ||
# this job is re-attempted as part of the same workflow run after | ||
# succeeding previously. | ||
- name: Save pip's install cache on job completion | ||
uses: actions/cache@v4 | ||
with: | ||
path: ~/.cache/pip | ||
# key determines if we define or reuse an existing cache or not. Our | ||
# key ensure we cache within a workflow run and its attempts, but not | ||
# between workflow runs. | ||
key: "${{ github.run_id }}" | ||
- name: Install deployer script's Python dependencies | ||
run: | | ||
pip install --editable . | ||
pip list | ||
- name: Get merged/open PR labels | ||
uses: actions/github-script@v7 | ||
id: pr-labels | ||
with: | ||
# Both pull_request and push can have triggered this job to run. A | ||
# context with PR info (including its labels) is available when this | ||
# job is triggered via pull_request, but not when triggered via push - | ||
# a push can be triggered by other things than merged PRs. Due to | ||
# this, we check if a pushed commit is matching some PRs merge commit, | ||
# and if so gets its labels. | ||
script: | | ||
let labels = null; | ||
if (context.eventName === 'pull_request') { | ||
labels = context.payload.pull_request.labels; | ||
} | ||
else if (context.eventName === 'push') { | ||
// api ref: https://octokit.github.io/rest.js/v20#pulls-list | ||
const resp = await github.rest.pulls.list( | ||
{ | ||
owner: context.repo.owner, | ||
repo: context.repo.repo, | ||
state: 'closed', | ||
sort: 'updated', | ||
direction: 'desc', | ||
per_page: 100, | ||
} | ||
); | ||
const merged_pr = resp.data.find(pr => pr.merge_commit_sha === context.sha); | ||
labels = merged_pr?.labels; | ||
} | ||
label_names = (labels || []).map(l => l.name); | ||
return label_names | ||
- name: Identify files that have been added or modified | ||
# Action repo: https://github.com/dorny/paths-filter | ||
uses: dorny/paths-filter@v3 | ||
id: changed-files | ||
with: | ||
token: "" | ||
list-files: csv | ||
filters: | | ||
changed: | ||
- added|modified: deployer/** | ||
- added|modified: requirements.txt | ||
- added|modified: .github/actions/setup-deploy/** | ||
- added|modified: helm-charts/basehub/** | ||
- added|modified: helm-charts/daskhub/** | ||
- added|modified: helm-charts/support/** | ||
- added|modified: config/clusters/** | ||
# This step will create a comment-body.txt file containing the jobs to be run in a | ||
# Markdown table format to be posted on a Pull Request, if this job is triggered | ||
# by one | ||
- name: Generate matrix jobs | ||
run: | | ||
deployer generate helm-upgrade-jobs "${{ steps.changed-files.outputs.changed_files }}" '${{ steps.pr-labels.outputs.result }}' | ||
# The comment-deployment-plan-pr.yaml workflow won't have the correct context to | ||
# know the PR number, so we save it to a file to pass to that workflow | ||
- name: Save Pull Request number to a file | ||
if: github.event_name == 'pull_request' | ||
run: | | ||
echo "${{ github.event.number }}" > pr-number.txt | ||
# Upload the pr-number.txt and comment-body.txt files as artifacts for the | ||
# comment-deployment-plan-pr.yaml workflow to access | ||
- name: Upload artifacts | ||
if: > | ||
github.event_name == 'pull_request' && | ||
(env.support-matrix-jobs != '[]' || | ||
env.staging-hub-matrix-jobs != '[]' || | ||
env.prod-hub-matrix-jobs != '[]') | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: pr | ||
path: | | ||
pr-number.txt | ||
comment-body.txt | ||
# https://github.com/ravsamhq/notify-slack-action | ||
# Needs to be added per job | ||
# When https://github.com/integrations/slack/issues/1563 gets implemented, | ||
# we can use that instead | ||
- name: Report Status | ||
if: always() | ||
uses: ravsamhq/notify-slack-action@v2 | ||
with: | ||
# Warning: there are multiple "Report Status" steps in this file (one per job). | ||
# Make sure they are all updated | ||
notify_when: "failure" | ||
status: ${{ job.status }} # required | ||
# Message should look like: "Hey @author! Deploy and test hubs failed for "Add new hub - 9305e08". | ||
message_format: '{emoji} Hey @${{ github.event.head_commit.author.name }}! *{workflow}* {status_message} for "${{ github.event.head_commit.message }} - <{commit_url}|{commit_sha}>". Checkout the run at {run_url}.' | ||
footer: "<{run_url}|Failing Run>" | ||
env: | ||
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_FAILURES_WEBHOOK_URL }} | ||
# This job upgrades the support chart for clusters in parallel, if those upgrades | ||
# are required. This job needs the `generate-jobs` job to have completed and set | ||
# an output to the `support-matrix-jobs` variable name. It's inputs are a list of | ||
# dictionaries with the keys cluster_name, provider, and upgrade_support for each | ||
# cluster that requires it. | ||
upgrade-support: | ||
runs-on: ubuntu-latest | ||
needs: [generate-jobs] | ||
# We declare outputs indicating the job failed status of a specific job | ||
# variation. We are currently required to do this in a hardcoded fashion, | ||
# see this post for feature requests for this to be improved: | ||
# https://github.community/t/bug-jobs-output-should-return-a-list-for-a-matrix-job/128626/32?u=consideratio | ||
# | ||
# Warning: names can include alphanumerics, '-', and '_', but not '.', so | ||
# we replace '.' for '-' in cluster names. | ||
# | ||
# If you are adding a new cluster, please remember to list it here! | ||
outputs: | ||
failure_2i2c-aws-us: "${{ env.failure_2i2c-aws-us }}" | ||
failure_2i2c-uk: "${{ env.failure_2i2c-uk }}" | ||
failure_2i2c: "${{ env.failure_2i2c }}" | ||
failure_awi-ciroh: "${{ env.failure_awi-ciroh }}" | ||
failure_catalystproject-africa: "${{ env.failure_catalystproject-africa }}" | ||
failure_catalystproject-latam: "${{ env.failure_catalystproject-latam }}" | ||
failure_cloudbank: "${{ env.failure_cloudbank }}" | ||
failure_dubois: "${{ env.failure_dubois }}" | ||
failure_earthscope: "${{ env.failure_earthscope }}" | ||
failure_gridsst: "${{ env.failure_gridsst }}" | ||
failure_hhmi: "${{ env.failure_hhmi }}" | ||
failure_jupyter-health: "${{ env.failure_jupyter-health }}" | ||
failure_jupyter-meets-the-earth: "${{ env.failure_jupyter-meets-the-earth }}" | ||
failure_kitware: "${{ env.failure_kitware }}" | ||
failure_leap: "${{ env.failure_leap }}" | ||
failure_maap: "${{ env.failure_maap }}" | ||
failure_nasa-cryo: "${{ env.failure_nasa-cryo }}" | ||
failure_nasa-ghg: "${{ env.failure_nasa-ghg }}" | ||
failure_nasa-veda: "${{ env.failure_nasa-veda }}" | ||
failure_nmfs-openscapes: "${{ env.failure_nmfs-openscapes }}" | ||
failure_openscapes: "${{ env.failure_openscapes }}" | ||
failure_opensci: "${{ env.failure_opensci }}" | ||
failure_pangeo-hubs: "${{ env.failure_pangeo-hubs }}" | ||
failure_projectpythia: "${{ env.failure_projectpythia }}" | ||
failure_queensu: "${{ env.failure_queensu }}" | ||
failure_smithsonian: "${{ env.failure_smithsonian }}" | ||
failure_strudel: "${{ env.failure_strudel }}" | ||
failure_ubc-eoas: "${{ env.failure_ubc-eoas }}" | ||
failure_utoronto: "${{ env.failure_utoronto }}" | ||
failure_victor: "${{ env.failure_victor }}" | ||
if: | | ||
(github.event_name == 'push' && contains(github.ref, 'main')) && | ||
needs.generate-jobs.result == 'success' && | ||
needs.generate-jobs.outputs.support-matrix-jobs != '[]' | ||
strategy: | ||
# Don't stop other deployments if one fails | ||
fail-fast: false | ||
matrix: | ||
jobs: ${{ fromJson(needs.generate-jobs.outputs.support-matrix-jobs) }} | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Setup deploy for ${{ matrix.jobs.cluster_name }} | ||
uses: ./.github/actions/setup-deploy | ||
with: | ||
provider: ${{ matrix.jobs.provider }} | ||
GCP_KMS_DECRYPTOR_KEY: ${{ secrets.GCP_KMS_DECRYPTOR_KEY }} | ||
- name: Upgrade support chart on cluster ${{ matrix.jobs.cluster_name }} | ||
if: matrix.jobs.upgrade_support | ||
run: | | ||
deployer deploy-support ${{ matrix.jobs.cluster_name }} | ||
- name: Declare failure status | ||
if: always() | ||
shell: python | ||
run: | | ||
import os | ||
name = "${{ matrix.jobs.cluster_name }}".replace(".", "-") | ||
failure = "${{ job.status == 'failure' }}" | ||
env_file = os.getenv("GITHUB_ENV") | ||
with open(env_file, "a") as f: | ||
f.write(f"failure_{name}={failure}") | ||
# https://github.com/ravsamhq/notify-slack-action | ||
# Needs to be added per job | ||
# FIXME: when https://github.com/integrations/slack/issues/1563 gets implemented, | ||
# we can use that instead | ||
- name: Report Status | ||
if: always() | ||
uses: ravsamhq/notify-slack-action@v2 | ||
# Warning: there are multiple "Report Status" steps in this file (one per job). | ||
# Make sure they are all updated | ||
with: | ||
notify_when: "failure" | ||
status: ${{ job.status }} # required | ||
# Message should look like: "Hey @author! Deploy and test hubs failed for "Add new hub - 9305e08". | ||
message_format: '{emoji} Hey @${{ github.event.head_commit.author.name }}! *{workflow}* {status_message} for "${{ github.event.head_commit.message }} - <{commit_url}|{commit_sha}>". Checkout the run at {run_url}.' | ||
footer: "<{run_url}|Failing Run>" | ||
env: | ||
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_FAILURES_WEBHOOK_URL }} | ||
# This job reduces the initially planned staging-hub-matrix-jobs and | ||
# prod-hub-matrix-jobs deployments by filtering out any deployment to a cluster | ||
# with a failed support job. | ||
filter-failed-support-jobs: | ||
runs-on: ubuntu-latest | ||
needs: [generate-jobs, upgrade-support] | ||
if: | | ||
!cancelled() && | ||
(github.event_name == 'push' && contains(github.ref, 'main')) && | ||
needs.generate-jobs.result == 'success' && | ||
needs.generate-jobs.outputs.staging-hub-matrix-jobs != '[]' && | ||
needs.generate-jobs.outputs.prod-hub-matrix-jobs != '[]' | ||
outputs: | ||
filtered-staging-hub-matrix-jobs: ${{ env.filtered-staging-hub-matrix-jobs}} | ||
filtered-prod-hub-matrix-jobs: ${{ env.filtered-prod-hub-matrix-jobs }} | ||
steps: | ||
# This Python script filters out any staging and/or prod hub deployment job | ||
# from running later based on if its part of a cluster where support upgrade | ||
# just failed. Data is injected to the script before its executed via | ||
# string literals as rendered GitHub workflow expressions. | ||
- name: Filter staging and prod deploy jobs to run based on failures in support | ||
shell: python | ||
run: | | ||
import os | ||
import json | ||
staging_jobs = json.loads(r"""${{ needs.generate-jobs.outputs.staging-hub-matrix-jobs}}""") | ||
prod_jobs = json.loads(r"""${{ needs.generate-jobs.outputs.prod-hub-matrix-jobs }}""") | ||
outputs = json.loads(r"""${{ toJson(needs.upgrade-support.outputs) }}""") | ||
try: | ||
filtered_staging_jobs = [ | ||
staging_job | ||
for staging_job in staging_jobs | ||
if outputs[f"failure_{staging_job['cluster_name'].replace('.', '-')}"] != "true" | ||
] | ||
filtered_prod_jobs = [ | ||
prod_job | ||
for prod_job in prod_jobs | ||
if outputs[f"failure_{prod_job['cluster_name'].replace('.', '-')}"] != "true" | ||
] | ||
except KeyError: | ||
print(f"The {cluster_name} cluster wasn't found in the `upgrade-support.outputs` list. Please add it before continuing!") | ||
env_file = os.getenv("GITHUB_ENV") | ||
with open(env_file, "a") as f: | ||
f.write(f"filtered-staging-hub-matrix-jobs={json.dumps(filtered_staging_jobs)}\n") | ||
f.write(f"filtered-prod-hub-matrix-jobs={json.dumps(filtered_prod_jobs)}") | ||
# https://github.com/ravsamhq/notify-slack-action | ||
# Needs to be added per job | ||
# When https://github.com/integrations/slack/issues/1563 gets implemented, | ||
# we can use that instead | ||
- name: Report Status | ||
if: always() | ||
uses: ravsamhq/notify-slack-action@v2 | ||
with: | ||
# Warning: there are multiple "Report Status" steps in this file (one per job). | ||
# Make sure they are all updated | ||
notify_when: "failure" | ||
status: ${{ job.status }} # required | ||
# Message should look like: "Hey @author! Deploy and test hubs failed for "Add new hub - 9305e08". | ||
message_format: '{emoji} Hey @${{ github.event.head_commit.author.name }}! *{workflow}* {status_message} for "${{ github.event.head_commit.message }} - <{commit_url}|{commit_sha}>". Checkout the run at {run_url}.' | ||
footer: "<{run_url}|Failing Run>" | ||
env: | ||
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_FAILURES_WEBHOOK_URL }} | ||
# This job upgrades staging hubs on clusters in parallel, if required. This | ||
# job needs the `filter-failed-support-jobs` to have completed to provide its | ||
# output `filtered-staging-hub-matrix-jobs`. It is a list of dictionaries with | ||
# the keys cluster_name, provider, and hub_name for each staging hub that | ||
# requires an upgrade and didn't have a failed support-upgrade job | ||
# run as part of this workflow. | ||
upgrade-staging-hubs: | ||
runs-on: ubuntu-latest | ||
needs: [filter-failed-support-jobs] | ||
if: | | ||
!cancelled() && | ||
(github.event_name == 'push' && contains(github.ref, 'main')) && | ||
needs.filter-failed-support-jobs.result == 'success' && | ||
needs.filter-failed-support-jobs.outputs.filtered-staging-hub-matrix-jobs != '[]' | ||
strategy: | ||
# Don't stop other deployments if one fails | ||
fail-fast: false | ||
matrix: | ||
jobs: ${{ fromJson(needs.filter-failed-support-jobs.outputs.filtered-staging-hub-matrix-jobs) }} | ||
# We declare outputs indicating the job failed status of a specific job | ||
# variation. We are currently required to do this in a hardcoded fashion, | ||
# see this post for feature requests for this to be improved: | ||
# https://github.community/t/bug-jobs-output-should-return-a-list-for-a-matrix-job/128626/32?u=consideratio | ||
# | ||
# Warning: names can include alphanumerics, '-', and '_', but not '.', so | ||
# we replace '.' for '-' in cluster names. | ||
# | ||
# If you are adding a new cluster, please remember to list it here! | ||
outputs: | ||
failure_2i2c-aws-us: "${{ env.failure_2i2c-aws-us }}" | ||
failure_2i2c-uk: "${{ env.failure_2i2c-uk }}" | ||
failure_2i2c: "${{ env.failure_2i2c }}" | ||
failure_awi-ciroh: "${{ env.failure_awi-ciroh }}" | ||
failure_catalystproject-africa: "${{ env.failure_catalystproject-africa }}" | ||
failure_catalystproject-latam: "${{ env.failure_catalystproject-latam }}" | ||
failure_cloudbank: "${{ env.failure_cloudbank }}" | ||
failure_dubois: "${{ env.failure_dubois }}" | ||
failure_earthscope: "${{ env.failure_earthscope }}" | ||
failure_gridsst: "${{ env.failure_gridsst }}" | ||
failure_hhmi: "${{ env.failure_hhmi }}" | ||
failure_jupyter-health: "${{ env.failure_jupyter-health }}" | ||
failure_jupyter-meets-the-earth: "${{ env.failure_jupyter-meets-the-earth }}" | ||
failure_kitware: "${{ env.failure_kitware }}" | ||
failure_leap: "${{ env.failure_leap }}" | ||
failure_maap: "${{ env.failure_maap }}" | ||
failure_nasa-cryo: "${{ env.failure_nasa-cryo }}" | ||
failure_nasa-ghg: "${{ env.failure_nasa-ghg }}" | ||
failure_nasa-veda: "${{ env.failure_nasa-veda }}" | ||
failure_nmfs-openscapes: "${{ env.failure_nmfs-openscapes }}" | ||
failure_openscapes: "${{ env.failure_openscapes }}" | ||
failure_opensci: "${{ env.failure_opensci }}" | ||
failure_pangeo-hubs: "${{ env.failure_pangeo-hubs }}" | ||
failure_projectpythia: "${{ env.failure_projectpythia }}" | ||
failure_queensu: "${{ env.failure_queensu }}" | ||
failure_smithsonian: "${{ env.failure_smithsonian }}" | ||
failure_strudel: "${{ env.failure_strudel }}" | ||
failure_ubc-eoas: "${{ env.failure_ubc-eoas }}" | ||
failure_utoronto: "${{ env.failure_utoronto }}" | ||
failure_victor: "${{ env.failure_victor }}" | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Setup deploy for ${{ matrix.jobs.cluster_name }} cluster | ||
uses: ./.github/actions/setup-deploy | ||
with: | ||
provider: ${{ matrix.jobs.provider }} | ||
GCP_KMS_DECRYPTOR_KEY: ${{ secrets.GCP_KMS_DECRYPTOR_KEY }} | ||
- name: Upgrade ${{ matrix.jobs.hub_name }} hub on cluster ${{ matrix.jobs.cluster_name }} | ||
run: | | ||
deployer deploy ${{ matrix.jobs.cluster_name }} ${{ matrix.jobs.hub_name }} | ||
# Retry action: https://github.com/marketplace/actions/retry-step | ||
- name: Run health check against ${{ matrix.jobs.hub_name }} hub on cluster ${{ matrix.jobs.cluster_name}} | ||
uses: nick-fields/retry@v3 | ||
with: | ||
timeout_minutes: 10 | ||
max_attempts: 3 | ||
command: | | ||
deployer run-hub-health-check ${{ matrix.jobs.cluster_name }} ${{ matrix.jobs.hub_name }} | ||
- name: Declare failure status | ||
if: always() | ||
shell: python | ||
run: | | ||
import os | ||
name = "${{ matrix.jobs.cluster_name }}".replace(".", "-") | ||
failure = "${{ job.status == 'failure' }}" | ||
env_file = os.getenv("GITHUB_ENV") | ||
with open(env_file, "a") as f: | ||
f.write(f"failure_{name}={failure}") | ||
# https://github.com/ravsamhq/notify-slack-action | ||
# Needs to be added per job | ||
# When https://github.com/integrations/slack/issues/1563 gets implemented, | ||
# we can use that instead | ||
- name: Report Status | ||
if: always() | ||
uses: ravsamhq/notify-slack-action@v2 | ||
with: | ||
# Warning: there are multiple "Report Status" steps in this file (one per job). | ||
# Make sure they are all updated | ||
notify_when: "failure" | ||
status: ${{ job.status }} # required | ||
# Message should look like: "Hey @author! Deploy and test hubs failed for "Add new hub - 9305e08". | ||
message_format: '{emoji} Hey @${{ github.event.head_commit.author.name }}! *{workflow}* {status_message} for "${{ github.event.head_commit.message }} - <{commit_url}|{commit_sha}>". Checkout the run at {run_url}.' | ||
footer: "<{run_url}|Failing Run>" | ||
env: | ||
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_FAILURES_WEBHOOK_URL }} | ||
# This job further reduces the filtered-prod-hub-matrix-jobs and deployments by | ||
# filtering out any deployment to a cluster with a failed staging hub job. | ||
filter-failed-staging-jobs: | ||
runs-on: ubuntu-latest | ||
needs: [generate-jobs, filter-failed-support-jobs, upgrade-staging] | ||
Check failure on line 506 in .github/workflows/deploy-hubs.yaml GitHub Actions / Deploy and test hubsInvalid workflow file
|
||
if: | | ||
!cancelled() && | ||
(github.event_name == 'push' && contains(github.ref, 'main')) && | ||
needs.generate-jobs.result == 'success' && | ||
needs.filter-failed-support-jobs.outputs.filtered-prod-hub-matrix-jobs != '[]' | ||
outputs: | ||
refiltered-prod-hub-matrix-jobs: ${{ env.refiltered-prod-hub-matrix-jobs }} | ||
steps: | ||
# This Python script filters out any prod hub deployment job from running | ||
# later based on if its part of a cluster where staging hub upgrade | ||
# just failed. Data is injected to the script before its executed via | ||
# string literals as rendered GitHub workflow expressions. | ||
- name: Filter prod deploy jobs to run based on failures in staging | ||
shell: python | ||
run: | | ||
import os | ||
import json | ||
prod_jobs = json.loads(r"""${{ needs.filter-failed-support-jobs.outputs.filtered-prod-hub-matrix-jobs }}""") | ||
outputs = json.loads(r"""${{ toJson(needs.upgrade-staging.outputs) }}""") | ||
try: | ||
filtered_prod_jobs = [ | ||
prod_job | ||
for prod_job in prod_jobs | ||
if outputs[f"failure_{prod_job['cluster_name'].replace('.', '-')}"] != "true" | ||
] | ||
except KeyError: | ||
print(f"The {cluster_name} cluster wasn't found in the `upgrade-staging.outputs` list. Please add it before continuing!") | ||
env_file = os.getenv("GITHUB_ENV") | ||
with open(env_file, "a") as f: | ||
f.write(f"refiltered-prod-hub-matrix-jobs={json.dumps(filtered_prod_jobs)}") | ||
# https://github.com/ravsamhq/notify-slack-action | ||
# Needs to be added per job | ||
# When https://github.com/integrations/slack/issues/1563 gets implemented, | ||
# we can use that instead | ||
- name: Report Status | ||
if: always() | ||
uses: ravsamhq/notify-slack-action@v2 | ||
with: | ||
# Warning: there are multiple "Report Status" steps in this file (one per job). | ||
# Make sure they are all updated | ||
notify_when: "failure" | ||
status: ${{ job.status }} # required | ||
# Message should look like: "Hey @author! Deploy and test hubs failed for "Add new hub - 9305e08". | ||
message_format: '{emoji} Hey @${{ github.event.head_commit.author.name }}! *{workflow}* {status_message} for "${{ github.event.head_commit.message }} - <{commit_url}|{commit_sha}>". Checkout the run at {run_url}.' | ||
footer: "<{run_url}|Failing Run>" | ||
env: | ||
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_FAILURES_WEBHOOK_URL }} | ||
# This job upgrades production hubs on clusters in parallel, if required. This | ||
# job needs the `filter-failed-staging-jobs` to have completed to provide its | ||
# output `filtered-prod-hub-matrix-jobs`. It is a list of dictionaries with | ||
# the keys cluster_name, provider, and hub_name for each production hub that | ||
# requires an upgrade and didn't have a failed upgrade-staging-hub job | ||
# run as part of this workflow. | ||
upgrade-prod-hubs: | ||
runs-on: ubuntu-latest | ||
needs: [filter-failed-staging-jobs] | ||
if: | | ||
!cancelled() && | ||
(github.event_name == 'push' && contains(github.ref, 'main')) && | ||
needs.filter-failed-staging-jobs.result == 'success' && | ||
needs.filter-failed-staging-jobs.outputs.refiltered-prod-hub-matrix-jobs != '[]' | ||
strategy: | ||
# Don't stop other deployments if one fails | ||
fail-fast: false | ||
matrix: | ||
jobs: ${{ fromJson(needs.filter-failed-staging-jobs.outputs.refiltered-prod-hub-matrix-jobs) }} | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Setup deploy for ${{ matrix.jobs.cluster_name }} cluster | ||
uses: ./.github/actions/setup-deploy | ||
with: | ||
provider: ${{ matrix.jobs.provider }} | ||
GCP_KMS_DECRYPTOR_KEY: ${{ secrets.GCP_KMS_DECRYPTOR_KEY }} | ||
- name: Upgrade ${{ matrix.jobs.hub_name }} hub on cluster ${{ matrix.jobs.cluster_name }} | ||
run: | | ||
deployer deploy ${{ matrix.jobs.cluster_name }} ${{ matrix.jobs.hub_name }} | ||
# Retry action: https://github.com/marketplace/actions/retry-step | ||
- name: Run health check against ${{ matrix.jobs.hub_name }} hub on cluster ${{ matrix.jobs.cluster_name}} | ||
uses: nick-fields/retry@v3 | ||
with: | ||
timeout_minutes: 10 | ||
max_attempts: 3 | ||
command: | | ||
deployer run-hub-health-check ${{ matrix.jobs.cluster_name }} ${{ matrix.jobs.hub_name }} | ||
# https://github.com/ravsamhq/notify-slack-action | ||
# Needs to be added per job | ||
# When https://github.com/integrations/slack/issues/1563 gets implemented, | ||
# we can use that instead | ||
- name: Report Status | ||
if: always() | ||
uses: ravsamhq/notify-slack-action@v2 | ||
with: | ||
# Warning: there are multiple "Report Status" steps in this file (one per job). | ||
# Make sure they are all updated | ||
notify_when: "failure" | ||
status: ${{ job.status }} # required | ||
# Message should look like: "Hey @author! Deploy and test hubs failed for "Add new hub - 9305e08". | ||
message_format: '{emoji} Hey @${{ github.event.head_commit.author.name }}! *{workflow}* {status_message} for "${{ github.event.head_commit.message }} - <{commit_url}|{commit_sha}>". Checkout the run at {run_url}.' | ||
footer: "<{run_url}|Failing Run>" | ||
env: | ||
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_GHA_FAILURES_WEBHOOK_URL }} |