Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup redudant cluster config that was re-setting default values #3208

Merged
merged 2 commits into from
Oct 2, 2023

Conversation

consideRatio
Copy link
Contributor

  • refactor: cleanup redundant config about dask-gateway idle_timeout
  • refactor: cleanup redundant config about matchNodePurpose

@consideRatio consideRatio requested a review from a team as a code owner October 2, 2023 09:25
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Merging this PR will trigger the following deployment actions.

Support and Staging deployments

Cloud Provider Cluster Name Upgrade Support? Reason for Support Redeploy Upgrade Staging? Reason for Staging Redeploy
aws jupyter-meets-the-earth No Yes Following helm chart values files were modified: common.values.yaml
aws carbonplan No Yes Following helm chart values files were modified: common.values.yaml
aws openscapes No Yes Following helm chart values files were modified: common.values.yaml
gcp meom-ige No Yes Following helm chart values files were modified: common.values.yaml

Production deployments

Cloud Provider Cluster Name Hub Name Reason for Redeploy
aws jupyter-meets-the-earth prod Following helm chart values files were modified: common.values.yaml
aws carbonplan prod Following helm chart values files were modified: common.values.yaml
aws openscapes prod Following helm chart values files were modified: common.values.yaml
gcp meom-ige prod Following helm chart values files were modified: common.values.yaml

Copy link
Member

@yuvipanda yuvipanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming idle_timeout is now specified upstream? If so, good to go

@consideRatio
Copy link
Contributor Author

I'm assuming idle_timeout is now specified upstream? If so, good to go

Yepp in our own daskhub helm chart's default values - see

idle: |
# timeout after 30 minutes of inactivity
c.KubeClusterConfig.idle_timeout = 1800

@consideRatio consideRatio merged commit 2adbba5 into 2i2c-org:master Oct 2, 2023
10 checks passed
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

🎉🎉🎉🎉

Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/6384660846

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

2 participants