support chart, node-exporter: tolerate 2i2c.org/community tainted nodes #3209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
consideRatio
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
consideRatio
commented
Oct 2, 2023
Comment on lines
87
to
-102
| prometheus-node-exporter: | ||
| tolerations: | ||
| # Tolerate tainted jupyterhub user nodes | ||
| - key: hub.jupyter.org_dedicated | ||
| value: user | ||
| effect: NoSchedule | ||
| - key: hub.jupyter.org/dedicated | ||
| value: user | ||
| effect: NoSchedule | ||
| # Tolerate tainted dask worker nodes | ||
| - key: k8s.dask.org_dedicated | ||
| value: worker | ||
| effect: NoSchedule | ||
| - key: k8s.dask.org/dedicated | ||
| value: worker | ||
| effect: NoSchedule |
There was a problem hiding this comment.
These are the chart's defaults:
tolerations:
- effect: NoSchedule
operator: Exists
|
Thank you @yuvipanda for reviewing!! |
|
🎉🎉🎉🎉 Monitor the deployment of the hubs here 👉 https://github.com/2i2c-org/infrastructure/actions/runs/6384535727 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The prometheus-node-exporter chart declares node taint tolerations by default in a way that it allows node-exporter to schedule on nodes with a "NoSchedule" taint, no matter what kind of key/value that goes with the effect of "NoSchedule".
This makes more sense for us than to declare tolerations for all individual taints we may declare, such as 2i2c.org/community.
Without this fix, we end up without node-exporter running on 2i2c.org/community tainted nodes, which in turn makes us unable to get statistics about user pods cpu and memory usage etc for pods on such nodes.