Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert terraform version bump #5050

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

yuvipanda
Copy link
Member

Partially reverts #4745, as Terraform 1.9 is not an open source product.

Partially reverts 2i2c-org#4745,
as Terraform 1.9 is not an open source product.
@yuvipanda
Copy link
Member Author

We will need to verify that this doesn't have any negative effects on the workspaces we currently maintain in the two months it's been in effect before merging it.

@consideRatio
Copy link
Contributor

I think this is just changing the lower bound, but that the upper bound would remain unchanged

@consideRatio
Copy link
Contributor

It seems 1.5.7 is the latest terraform with old license https://github.com/hashicorp/terraform/blob/v1.5.7/LICENSE.

@@ -1,5 +1,5 @@
terraform {
required_version = "~> 1.9"
required_version = "~> 1.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
required_version = "~> 1.5"
required_version = "~> 1.5.7"

This would change the lower bound from 1.x to 1.5.x

@@ -1,6 +1,6 @@

terraform {
required_version = "~> 1.9"
required_version = "~> 1.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
required_version = "~> 1.5"
required_version = "~> 1.5.7"

@@ -1,5 +1,5 @@
terraform {
required_version = "~> 1.9"
required_version = "~> 1.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
required_version = "~> 1.5"
required_version = "~> 1.5.7"

@@ -1,5 +1,5 @@
terraform {
required_version = "~> 1.9"
required_version = "~> 1.5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
required_version = "~> 1.5"
required_version = "~> 1.5.7"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants