Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jupyter-health: test oauthenticator 17.2 and skip refresh for the test user #5226

Merged
merged 2 commits into from
Dec 4, 2024
Merged

jupyter-health: test oauthenticator 17.2 and skip refresh for the test user #5226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e0fa32
Use oauthenticator branch to skip refresh for test user
GeorgianaElena Dec 4, 2024
0f795a3
Experiment with latest tag
GeorgianaElena Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions config/clusters/jupyter-health/staging.values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ jupyterhub:
- hosts: [staging.jupyter-health.2i2c.cloud]
secretName: https-auto-tls
hub:
# FIXME: Experiment to use https://github.com/jupyterhub/oauthenticator/pull/780
image:
name: quay.io/2i2c/pkce-experiment
tag: 0.0.1-0.dev.git.11169.h1e0fa323
config:
JupyterHub:
# Uses CHCS auth provider
Expand Down Expand Up @@ -48,6 +52,17 @@ jupyterhub:
spawner.environment["JHE_CLIENT_ID"] = "Ima7rx8D6eko0PzlU1jK28WBUT2ZweZj7mqVG2wm"

c.Spawner.auth_state_hook = auth_state_env

skip_refresh_for_test_user.py: |
def refresh_user_hook(authenticator, user, auth_state):
if user.name == "deployment-service-check":
# if this is the user,
# refresh_user doesn't make sense
# consider it always fresh
return True
# for all other users, refresh as usual
return None
c.OAuthenticator.refresh_user_hook = refresh_user_hook
singleuser:
nodeSelector:
2i2c/hub-name: staging
3 changes: 2 additions & 1 deletion helm-charts/images/hub/pkce-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
# install oauthenticator 17.1,
# which adds PKCE support.
# experiment no longer needed when base chart is updated to z2jh 4.0.0
oauthenticator>=17.1,<18
# Experiment with https://github.com/jupyterhub/oauthenticator/pull/780 and oauthenticator 17.2
git+https://github.com/minrk/oauthenticator@refresh-skip


# jupyterhub-configurator isn't maintained and its not intended to be developed
Expand Down
Loading