Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDLE-000] 크롤링 주기 변경 및 테스트용 에러 로그 추가 #233

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

wonjunYou
Copy link
Contributor

@wonjunYou wonjunYou commented Nov 8, 2024

1. 📄 Summary

  • 크롤링 주기 변경 및 테스트용 에러 로그 추가

Summary by CodeRabbit

  • 새로운 기능

    • 작업 스케줄링 빈도를 매일 특정 시간에서 15분마다로 변경했습니다.
    • 오류 발생 시 요약을 출력하는 printErrorSummary 메서드를 추가했습니다.
  • 버그 수정

    • 여러 메서드에서 오류 처리 및 로깅을 개선하여 더 나은 추적 및 보고 기능을 제공합니다.

@wonjunYou wonjunYou self-assigned this Nov 8, 2024
@wonjunYou wonjunYou added the ✨기능 기능 개발 및 구현 label Nov 8, 2024
Copy link

coderabbitai bot commented Nov 8, 2024

Warning

Rate limit exceeded

@wonjunYou has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 19 minutes and 58 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 2fc0228 and d531820.

Walkthrough

CrawlingJobScheduler.ktCrawlingJobScheduler 클래스에서 scheduleJob 메서드의 스케줄링 구성에 변경이 있었습니다. 크론 표현식이 "0 00 15 * * *"에서 "0 0/15 * * * *"로 변경되어, 작업 실행 빈도가 특정 시간(오후 3시)에서 매 15분으로 조정되었습니다. WorknetCrawler.ktWorknetCrawler 객체는 오류 처리 및 로깅 기능을 향상시키기 위해 여러 수정이 이루어졌습니다. 새로운 오류 카운트 맵이 도입되었고, 여러 메서드에서 오류 로깅이 추가되었습니다.

Changes

파일 경로 변경 요약
idle-batch/src/main/kotlin/com/swm/idle/batch/common/scheduler/CrawlingJobScheduler.kt scheduleJob 메서드의 크론 표현식이 "0 00 15 * * *"에서 "0 0/15 * * * *"로 변경되어 매 15분마다 작업이 실행되도록 조정됨.
idle-batch/src/main/kotlin/com/swm/idle/batch/util/WorknetCrawler.kt 오류 처리 및 로깅 기능 향상을 위해 여러 메서드에 try-catch 블록 추가, 새로운 errorCountMap 도입, printErrorSummary 메서드 추가.

Possibly related PRs

Suggested labels

✨기능, 🛠️버그


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@wonjunYou wonjunYou added 🎯리팩토링 리팩토링 및 고도화 이슈 and removed ✨기능 기능 개발 및 구현 labels Nov 8, 2024
@wonjunYou wonjunYou merged commit f04d2a0 into develop Nov 8, 2024
2 of 3 checks passed
@wonjunYou wonjunYou deleted the refactor/IDLE-000 branch November 8, 2024 06:59
Copy link

sonarcloud bot commented Nov 8, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯리팩토링 리팩토링 및 고도화 이슈
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant