Less decimals for bbox info on project view page #4032

nworr · 2023-12-18T09:46:22Z

Round value for project bounds in the project view page.

I also use a css transition instead of jquery slide

Ticket : #3558

Funded by 3Liz

gioman · 2023-12-19T18:00:39Z

Fixes #3558

Gustry

From a UX point of view, good.

Do you want to backport ?

nworr · 2023-12-20T09:01:09Z

only 3.7 ?

nworr · 2023-12-20T11:31:05Z

precision : it doesn't round values in the information panel

gioman · 2024-01-02T19:48:42Z

precision : it doesn't round values in the information panel

@nworr it would be highly appreciated if it would include also the info panel.

Also seems to me that

https://github.com/3liz/lizmap-web-client/pull/4032/files#diff-2c0e8b758097ca053a90b477e70751986f294f1d80fd8b85e0096e46dd21b4b0R38

just takes the first two decimal places from the bbox values, I think it would be better to round the values instead, and add some logic because for gepographical CRSs 2 decimal places is hardly enough to describe with precision an extent that has values in degrees (while is ok for projected CRSs).

rldhont · 2024-02-12T14:50:14Z

lizmap/modules/view/classes/lizmapMainViewItem.class.php

@@ -35,7 +35,7 @@ public function __construct($id, $title, $abstract = '', $keywordList = '', $pro
        $this->abstract = $abstract;
        $this->keywordList = $keywordList;
        $this->proj = $proj;
-        $this->bbox = $bbox;
+        $this->bbox = preg_replace('/([0-9]+\.[0-9]{2})[0-9]+/', '$1', $bbox);


Suggested change

$this->bbox = preg_replace('/([0-9]+\.[0-9]{2})[0-9]+/', '$1', $bbox);

$this->bbox = preg_replace('/([0-9]+\.[0-9]{6})[0-9]+/', '$1', $bbox);

Can you provide 6 decimals ?

Not sure if I get the code at all... From a UX it would be nice to show 2 decimal places (rounded) for projected CRS, 6 I guess would be ok for geographical ones (degrees). Six decimals for CRSs in meters or feet do not give a good UX.

Gustry · 2024-04-15T11:21:15Z

It's just my opinion, but these kind of information about extent, is not really human readible, and doesn't need to be displayed on the main landing page of Lizmap Web Client (which is the "page vitrine" of the LWC project, to give a first preview of the project).

If a GIS user wants to have it's extent, IMHO he should open the project and go in the information tab. It's really targeting precise GIS technicians be able to ready text representing coordinates.

I really like the work from @Jersig on his instance to make something "neat" and "slick" about the landing page of LWC : https://mapeo.calvados.fr/carto/index.php hiding quite a few complex information for most users.

Just my opinion (I got inspired from Spotify or Netflix apps, where just title, description and thumbnail are displayed nicely). All "secondary information" are coming in the second step (actors, producters,number of episodes). Sorry for the comparaison :)

github-actions · 2024-06-24T15:19:56Z

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

github-actions · 2024-07-01T15:19:27Z

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

github-actions · 2024-07-08T15:19:42Z

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

gioman · 2024-07-08T15:21:44Z

Not stale, actually a very welcome UX improvement (this would also need to be applied to the BBOX values as shown in the project infos after having opened the map, not only in the LMWC landing page).

nworr · 2024-07-08T15:39:29Z

This PR is now outdated, and have conflicts with master branch (and release_3_8 for sure).
The logic of simple rounding value is quite weak, as you noticed.
It need to use a smarter way to round value depending on projection unit, and it will be performed in another way (dedicated class/ method, maybe only on browser side).
Thus IMHO, another PR will be more relevant, and the original ticket keep track of this one which is usefull (even closed)

Gustry · 2024-07-08T15:50:05Z

IMHO, displaying coordinates in a web interface is very GIS technicians oriented. I don't think that reading coordinates is done by a lot of humans, in a web interface :)

I really would like to see something more user-friendly, similar to what Calvados has done for instance, slick, very oriented for non-GIS technicians :

gioman · 2024-07-09T19:05:32Z

@Gustry what I can say... I agree! but since that bbox values are shown since... always, I assumed that you wanted to keep them. If in reality you want to get rid of them, please go on!

Gustry · 2024-07-10T06:32:05Z

Ah great, as my previous comment just above last April didn't get attraction, and as you commented "not stale", I thought you were interested into this PR :D
I don't need these coordinates either ;-)

It looks IMHO easier to close this PR if we agree and to create a new one removing codes ;-)

This interface needs a more modern UI, which started in LWC 3.7 with this new theme. Hands are welcome, if you have some design, CSS skills etc.

@nworr, it's up to you :)

github-actions · 2024-07-10T15:20:32Z

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

github-actions · 2024-07-17T15:21:57Z

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

github-actions · 2024-07-24T15:20:07Z

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

github-actions · 2024-07-31T15:20:20Z

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

github-actions · 2024-12-16T15:24:04Z

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

nworr added 2 commits December 18, 2023 10:16

round bbox value

5ff9bba

use css transitions instead of js

d292663

github-actions bot added this to the 3.8.0 milestone Dec 18, 2023

Gustry approved these changes Dec 20, 2023

View reviewed changes

nworr added the backport release_3_7 label Dec 20, 2023

nworr mentioned this pull request Jan 5, 2024

use css transitions instead of js for project description #4055

Merged

nworr changed the title ~~Less decimals for bbox info on project view page~~ draft : Less decimals for bbox info on project view page Jan 5, 2024

nworr changed the title ~~draft : Less decimals for bbox info on project view page~~ Less decimals for bbox info on project view page Jan 5, 2024

nworr marked this pull request as draft January 5, 2024 13:43

rldhont requested changes Feb 12, 2024

View reviewed changes

nworr modified the milestones: 3.8.0, 3.9 May 13, 2024

Gustry added the backport release_3_8 label Jun 7, 2024

github-actions bot added stale This ticket might be closed soon and removed stale This ticket might be closed soon labels Jun 24, 2024

github-actions bot added stale This ticket might be closed soon and removed stale This ticket might be closed soon labels Jul 1, 2024

github-actions bot added the stale This ticket might be closed soon label Jul 8, 2024

3liz-bot removed the stale This ticket might be closed soon label Jul 8, 2024

github-actions bot added stale This ticket might be closed soon and removed stale This ticket might be closed soon labels Jul 10, 2024

github-actions bot added stale This ticket might be closed soon and removed stale This ticket might be closed soon labels Jul 17, 2024

github-actions bot added stale This ticket might be closed soon and removed stale This ticket might be closed soon labels Jul 24, 2024

github-actions bot added stale This ticket might be closed soon and removed stale This ticket might be closed soon labels Jul 31, 2024

Gustry removed backport release_3_7 backport release_3_8 labels Sep 17, 2024

Gustry modified the milestones: 3.9.0, 3.10.0 Oct 15, 2024

github-actions bot added stale This ticket might be closed soon and removed stale This ticket might be closed soon labels Dec 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Less decimals for bbox info on project view page #4032

Less decimals for bbox info on project view page #4032

nworr commented Dec 18, 2023

gioman commented Dec 19, 2023

Gustry left a comment

nworr commented Dec 20, 2023

nworr commented Dec 20, 2023

gioman commented Jan 2, 2024

rldhont Feb 12, 2024

gioman Feb 12, 2024

Gustry commented Apr 15, 2024

github-actions bot commented Jun 24, 2024

github-actions bot commented Jul 1, 2024

github-actions bot commented Jul 8, 2024

gioman commented Jul 8, 2024

nworr commented Jul 8, 2024

Gustry commented Jul 8, 2024

gioman commented Jul 9, 2024

Gustry commented Jul 10, 2024

github-actions bot commented Jul 10, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 24, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Dec 16, 2024

	$this->bbox = preg_replace('/([0-9]+\.[0-9]{2})[0-9]+/', '$1', $bbox);
	$this->bbox = preg_replace('/([0-9]+\.[0-9]{6})[0-9]+/', '$1', $bbox);

Less decimals for bbox info on project view page #4032

Are you sure you want to change the base?

Less decimals for bbox info on project view page #4032

Conversation

nworr commented Dec 18, 2023

gioman commented Dec 19, 2023

Gustry left a comment

Choose a reason for hiding this comment

nworr commented Dec 20, 2023

nworr commented Dec 20, 2023

gioman commented Jan 2, 2024

rldhont Feb 12, 2024

Choose a reason for hiding this comment

gioman Feb 12, 2024

Choose a reason for hiding this comment

Gustry commented Apr 15, 2024

github-actions bot commented Jun 24, 2024

github-actions bot commented Jul 1, 2024

github-actions bot commented Jul 8, 2024

gioman commented Jul 8, 2024

nworr commented Jul 8, 2024

Gustry commented Jul 8, 2024

gioman commented Jul 9, 2024

Gustry commented Jul 10, 2024

github-actions bot commented Jul 10, 2024

github-actions bot commented Jul 17, 2024

github-actions bot commented Jul 24, 2024

github-actions bot commented Jul 31, 2024

github-actions bot commented Dec 16, 2024