Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: filter form should take care of restricted user rights #4599

Draft
wants to merge 6,029 commits into
base: master
Choose a base branch
from

Conversation

nboisteault
Copy link
Member

@nboisteault nboisteault commented Jul 12, 2024

  • Log as admin
  • See only one point is visible
  • But filter form display all possible values

nboisteault and others added 30 commits April 30, 2024 11:00
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4.3.1 to 4.3.3.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v4.3.1...v4.3.3)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
The popup dock is build client side by the JS and depends on `lizDict`.
Since 3liz#4329 the popup dock could be created before the `lizDict` is available.
nboisteault and others added 14 commits July 4, 2024 16:53
In the main section of the JSON, add a new option to enable the automatic permalink : automatic_permalink.

It will be enabled by default.

Linked to 3liz/lizmap-plugin#590
New option to disable the automatic permalink
After 3liz#4586 that added `automatic_permalink` option
the default value will be false.
…link

Automatic permalink will be disabled by default
In embed mode the error is generated because the dataviz elements are not available.
```
TypeError: elem is null
    isInViewport dataviz.js:23
    getPlots dataviz.js:146
    uicreated dataviz.js:774
    triggerEvent OpenLayers.js:246
    init map.js:5034
map.js:5039:28
    init map.js:5039
```
Fix JS Dataviz: When dataviz is not available
@github-actions github-actions bot added this to the 3.9.0 milestone Jul 12, 2024
@nboisteault nboisteault changed the title Bug: form filter should take care of restricted user rights Bug: filter form should take care of restricted user rights Jul 12, 2024
@nboisteault
Copy link
Member Author

@mdouchin to discuss

@Gustry
Copy link
Member

Gustry commented Jul 15, 2024

Side note, but there is already filter_layer_by_user.qgs or similar project.
I think, I would appreciate if a project called filtered_layer_by_user has different aspects of this feature, like form filter.

Adding new layer doesn't matter, it takes times to update/upgrade a few projects for now).

Copy link

The Lizmap project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 2 months and is being automatically marked as "stale".
If there is no further activity on this pull request, it will be closed in two weeks.

@github-actions github-actions bot added stale This ticket might be closed soon and removed stale This ticket might be closed soon labels Sep 16, 2024
@Gustry Gustry modified the milestones: 3.9.0, 3.10.0 Oct 15, 2024
@nboisteault nboisteault force-pushed the form_filter_user-rights branch from 99b7c63 to b0fe582 Compare December 12, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants