-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BS5: migration follow up #4825
Open
nboisteault
wants to merge
6,302
commits into
3liz:master
Choose a base branch
from
nboisteault:finish-BS5-migration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
BS5: migration follow up #4825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: update `refresh data` button and fix export
Fix: avoid zoom to initial extent on window resize
fixes 3liz#4332 Currently, if the map allows you to go beyond the min/zoom resolution of a WMTS or XYZ source, Lizmap won't display anything beyond this min/zoom resolution. OpenLayers is able to do resampling. This can be seen when you zoom in progressively. OpenLayers must be forced to use the max zoom of the grid even when the user goes beyond it. The solution is described on stackoverflow https://stackoverflow.com/questions/43538345/how-to-force-load-tiles-for-lower-resolution and is based on `TileGrid`'s `getZForResolution` method https://github.com/openlayers/openlayers/blob/main/src/ol/tilegrid/TileGrid.js#L634 ```js getZForResolution(resolution, opt_direction) { const z = linearFindNearest( this.resolutions_, resolution, opt_direction || 0, ); return clamp(z, this.minZoom, this.maxZoom); } ``` This method is based on the `this.resolutions_` list of grid resolutions. The index of the resolution closest to that in parameter is then set to the min or max zoom value. So if `this.resolutions_` contains 24 values but maxZoom is 19, then when the map is at levels 20, 21, 22, 23 and 24, the grid will limit queries to zoom 19. Funded by FM Projet
Generic method to build scales based on options config.
Fixing tiles resolutions
* Native EPSG:3857 scales * Tiles resolutions
…yers Fix JS XYZ Grid Tile and Tests e2e playwrigth: enhancing base layers tests
…` event. In this case we run permalink
In some project the WMS Extent property of the project is empty. Funded by SETEC
Fix Project properties WMS Extent empty
Update attribute table project and e2e test to check table column order based on QGIS attribute table config.
Tests : Attribute Table config
UX - Provide a HTTP link about the main plugin homepage/help
Fix: allow tiled wms when `singleTile` is `false` and layer is not ca…
Tests - Improve Playwright helper to load a project with error
Show Lizmap modules infos
Tests - Add E2E test about user defined JavaScript warning
* fix typo, improve html for module view * declare Url repositoryAdmin liz global lizUrl * plugin homepage must be non empty to do a link * fix end2end modules line count
nboisteault
changed the title
BS5: add
BS5: migration follow up
Oct 1, 2024
form-select
class to <select>
nboisteault
added
run end2end
If the PR must run end2end tests or not
and removed
run end2end
If the PR must run end2end tests or not
labels
Oct 4, 2024
nboisteault
force-pushed
the
finish-BS5-migration
branch
from
December 12, 2024 16:30
a45e995
to
1398917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Funded by 3Liz