Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose value #77

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Choose value #77

wants to merge 3 commits into from

Conversation

SanjogSilawal
Copy link
Collaborator

while selection checkbox in choosing NFA, popup appears where you can enter values and save.
It sends data to server, but it doesnot save. As of now only front end works.

run NFADB.sql before running backend.

"Frontend works".

Copy link
Collaborator

@jmnietsch jmnietsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Currently always a "von bis" value pair is created, which is (originally) not what is intended, but this works and the rest is relatively easy to add.

Great work.
However I am not sure, if we actually want to show this feature tomorrow. (merge it, yes. Maybe show it, no)
Because it is only the frontend version:

My proposal: Add some "show_experimental : boolean = false;" to the class and add that to the surrounding *ngIf

If we want to show it then (spontanously), we can just change that variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants