devlib/utils/ssh.py: Fix set terminal window size #259
Conversation
Ensure that the terminal window size is set to 500x200, if not long commands (prompt + command > 80 chars) will fail because the pexpect search to match the command string in order to get the result and the command is wrapped to first 80 chars. In order to fix this scenario enables checkwinsize in the shell and use stty to set the new terminal window size. Signed-off-by: Aníbal Limón <[email protected]>
|
Related to, |
| @@ -72,9 +72,15 @@ def ssh_get_shell(host, username, password=None, keyfile=None, port=None, timeou | |||
| raise TargetError(message.format(host)) | |||
| time.sleep(5) | |||
|
|
|||
| conn.sendline('shopt -s checkwinsize') | |||
There was a problem hiding this comment.
Since we hit similar issue I had a look at this PR, and shopt is a bash-specific builtin, which does not exist in the busybox shell AFAIK (or even zsh, which uses set for similar purposes). I don't think that bash feature has equivalent in all shells, so it should probably not be relied on.
|
@marcbonnici That code has been replaced by the paramiko connection for quite a while now, so I think we can close this PR. A similar problem probably exists in the telnet connection but I honestly don't think telnet works at all in the current state. If we wanted to resurrect it, we would need to be able to multiplex multiple command output in the same terminal (for background command API), which is challenging. And at that rate, it may just be simpler to setup SLIP (IP over serial port) and use SSH |
Ensure that the terminal window size is set to 500x200, if not long
commands (prompt + command > 80 chars) will fail because the pexpect
search to match the command string in order to get the result and the
command is wrapped to first 80 chars.
In order to fix this scenario enables checkwinsize in the shell and use
stty to set the new terminal window size.
Signed-off-by: Aníbal Limón [email protected]