ftrace: Support trace-cmd record mode #643
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkajetanp
force-pushed
the
trace-cmd-record
branch
from
0e4f086
to
861e267
Compare
|
I pushed an update to make the entire collector just use a tempdir inside the working |
mrkajetanp
force-pushed
the
trace-cmd-record
branch
from
861e267
to
1c6b2c6
Compare
|
Updated to wait until the background command actually exits after sending |
The current implementation of the FtraceCollector only supports using ftrace in its start-stop mode which keeps the traces in memory and then writes to file at the end. Trace-cmd also supports a different mode - record which writes to file periodically meaning that it allows recording traces that would exceed the 'start' mode buffer size in exchange for added noise. This commit adds support for selecting which mode trace-cmd should be run in. It adds a new collector parameter - 'trace_cmd_mode' which is used to distinguish between the two approaches. While at it, it also cleans up the collector in some places, e.g. the teardown() method. Signed-off-by: Kajetan Puchalski <[email protected]>
The trace-cmd record mode allows setting the interval to determine how often it will write to the trace file. The default is 1000 (us, ie. 1ms). Add a collector parameter to allow setting that interval. This will only have an effect when trace_cmd_mode is 'record' as the option does not exist for 'start' mode. Signed-off-by: Kajetan Puchalski <[email protected]>
mrkajetanp
force-pushed
the
trace-cmd-record
branch
from
1c6b2c6
to
5ef563e
Compare
|
Pending on: #645 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the FtraceCollector only supports using ftrace in its start-stop mode which keeps the traces in memory and then writes to file at the end. Trace-cmd also supports a different mode - record which writes to file periodically meaning that it allows recording traces that would exceed the 'start' mode buffer size in exchange for added noise.
This commit adds support for selecting which mode trace-cmd should be run in. It adds a new collector parameter - 'trace_cmd_mode' which is used to distinguish between the two approaches.
While at it, it also cleans up the collector in some places, e.g. the teardown() method.