Extract mhtml content into Python dictionary #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bug fix: Handling `break` properly in `try-except` block.
|
My apologies for the delay in getting this reviewed, work has pretty much taken over most of my days. I'll see if I can take a look at this over the weekend! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breakproperly intry-exceptblock.I've modified some stuff in the extractor. Maybe it will be useful in certain scenarios. If you are using the script - with the presented modifications - inside Python code, you can extract mhtml content into Python dictionary. It is useful, if you need the content, but you don't want/need to handle files (e.g. if you only need to extract some info from html).