This repository has been archived by the owner on Dec 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 170
Fix various Python 3.12 SyntaxWarning #257
Open
elboulangero
wants to merge
542
commits into
Abacus-Group-RTO:master
Choose a base branch
from
elboulangero:fix-python-312-syntax-warnings
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix various Python 3.12 SyntaxWarning #257
elboulangero
wants to merge
542
commits into
Abacus-Group-RTO:master
from
elboulangero:fix-python-312-syntax-warnings
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed links to govanguard.com, added Keybase team link.
- Addresses github issue Abacus-Group-RTO#18
…c-bug-#18 Fix complex predicate bug
Update README typos and line wrapping
Merge latest dev into master
- Ran ui/eventfilter.py through CodeClimate CLI and is no longer showing any cognitive complexity issues in the logic
- The file was not loaded correctly by Legion on startup due to an error with a trailing single quote
- GitHub issue Abacus-Group-RTO#19 - Introduce concept of Shell - which should abstract all operations pertaining to lower level OS calls, e.g. creating/removing directories, etc. - This commit does not close issue Abacus-Group-RTO#19 but is part of a series of commits to spend down the technical debt surrounding `logic.py` file
- This commit is the 2nd iteration on reducing complexity of `logic.py` - Introduces the concept of a repository. A repository is an abstraction on a data store. In the case of Legion, the underlying data store is based on SQLite, and so the repository implementations should contain all SQL code within the app. - There is a repository for each concept within the app, such as a Process, a Service, a Host, a Port, etc. (e.g. ProcessRepository, HostRepository, etc.) - This commit does not complete the full refactoring of all SQL related code to a repository. Further commits will be added to complete the work. - All new code added was driven by an underlying unit test. In order to gain confidence in proper refactoring of existing logic, a backporting of unit tests was needed.
…c-bug-#18 Fix complexity bug in eventfilter
Fix unbalanced tickmark issue in legion.conf
…sue-19 Reduce cognitive complexity on logic.py
Update README.md
…e-cert-errors Added Cutycapt --insecure flag to ignore SSL/TLS certificate errors
…ate-progress-crash-1 Fix updateProgress to always use an integer
fix bad interpreter: /bin/bash^M: no such file or directory
Removed old dead links.
sscottgvit
force-pushed
the
master
branch
3 times, most recently
from
November 4, 2024 18:10
35e18d0
to
ea40ce5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.