# 42 - Add ExtractJson method - string from json path

[miroslavpojer]

• Introduced method 'string-from-json-path' in group: 'extractJson'.
• Improved error message in method 'body-contains-text' in group: 'assert'

Closes #42

[github-actions]

JaCoCo code coverage report - ScAPI

File	Coverage [85.19%]	🍏
ExtractJsonResponseActionType.scala	100%	🍏
ExtractJsonResponseAction.scala	92.43%	🍏
AssertionResponseAction.scala	83.5%	🍏

Total Project Coverage	88.37%	🍏

[dk1844]

Suggested change

	case StringFromList | StringFromJsonPath =>
	val cacheKey = responseAction.params("cacheKey")
	val listIndex = responseAction.params("listIndex").toInt
	val jsonKey = responseAction.params("jsonKey")
	val cacheLevel = responseAction.params("cacheLevel")
	stringFromList(response, cacheKey, listIndex, jsonKey, cacheLevel)
	action match {
	case StringFromList =>
	val jsonKey = responseAction.params("jsonKey")
	val listIndex = responseAction.params("listIndex").toInt
	stringFromList(response, cacheKey, listIndex, jsonKey, cacheLevel)
	case StringFromJsonPath =>
	val jsonPath = responseAction.params("jsonPath")
	stringFromJsonPath(response, jsonPath, cacheKey, cacheLevel)
	}
	case StringFromList =>
	val (cacheKey, cacheLevel) = cachingFunctionYieldingTuple()
	val jsonKey = responseAction.params("jsonKey")
	val listIndex = responseAction.params("listIndex").toInt
	stringFromList(response, cacheKey, listIndex, jsonKey, cacheLevel)
	case StringFromJsonPath =>
	val (cacheKey, cacheLevel) = cachingFunctionYieldingTuple()
	val jsonPath = responseAction.params("jsonPath")
	stringFromJsonPath(response, jsonPath, cacheKey, cacheLevel)
	}

Instead of matching twice just like this, rather match once and repeat one method call common for specific cases.

// e.g. but with a more fitting name :)
def cachingFunctionYieldingTuple() = {
  val cacheKey = responseAction.params("cacheKey")
  val cacheLevel = responseAction.params("cacheLevel")
  (cacheKey, cacheLevel)
}

[miroslavpojer]

Thank you for an improvement idea.
Fixed in commit 66e35c3.

[dk1844]

LGTM, just tiny suggestions