Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Ladislav Sulak <[email protected]>
  • Loading branch information
benedeki and lsulak authored Dec 4, 2024
1 parent d5054b6 commit f8c1d86
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import za.co.absa.atum.reader.server.ServerConfig
/**
* This class is a reader that reads data tight to a flow.
* @param mainFlowPartitioning - the partitioning of the main flow; renamed from ancestor's 'flowPartitioning'
* @param serverConfig - tha Atum server configuration
* @param serverConfig - the Atum server configuration
* @param backend - sttp backend, that will be executing the requests
* @param ev - using evidence based approach to ensure that the type F is a MonadError instead of using context
* bounds, as it make the imports easier to follow
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import za.co.absa.atum.reader.server.ServerConfig
/**
*
* @param partitioning - the Atum partitions to read the information from
* @param serverConfig - tha Atum server configuration
* @param serverConfig - the Atum server configuration
* @param backend - sttp backend, that will be executing the requests
* @param ev - using evidence based approach to ensure that the type F is a MonadError instead of using context
* bounds, as it make the imports easier to follow
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import za.co.absa.atum.reader.basic.RequestResult._

/**
* Reader is a base class for reading data from a remote server.
* @param serverConfig - the configuration hwo to reach the Atum server
* @param serverConfig - the configuration how to reach the Atum server
* @param backend - sttp backend to use to send requests
* @tparam F - the monadic effect used to get the data (e.g. Future, IO, Task, etc.)
* the context bind for the F type is MonadError to allow not just map, flatMap but eventually
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import za.co.absa.atum.reader.implicits.future.futureMonadError
import scala.concurrent.Future

class FlowReaderUnitTests extends AnyFunSuiteLike {
private implicit val severConfig: ServerConfig = ServerConfig.fromConfig()
private implicit val serverConfig: ServerConfig = ServerConfig.fromConfig()

test("mainFlowPartitioning is the same as partitioning") {
val atumPartitions: AtumPartitions = AtumPartitions(List(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import scala.concurrent.Future


class PartitioningReaderUnitTests extends AnyFunSuiteLike {
private implicit val severConfig: ServerConfig = ServerConfig.fromConfig()
private implicit val serverConfig: ServerConfig = ServerConfig.fromConfig()

test("foo") {
val atumPartitions: AtumPartitions = AtumPartitions(List(
Expand Down

0 comments on commit f8c1d86

Please sign in to comment.